You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/09/14 19:55:51 UTC
[GitHub] [geode] sabbeyPivotal opened a new pull request #5510: GEODE-8492: Redis 'clients' statistic goes negative
sabbeyPivotal opened a new pull request #5510:
URL: https://github.com/apache/geode/pull/5510
When running a long running app, we noticed that our "clients" statistic was negative. It should always be greater than or equal to 0.
It seems like the call to decrement the number of clients was being invoked multiple times for each client.
We created an atomic boolean to manage the client's closed state.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5510: GEODE-8492: Redis 'clients' statistic goes negative
Posted by GitBox <gi...@apache.org>.
sabbeyPivotal commented on a change in pull request #5510:
URL: https://github.com/apache/geode/pull/5510#discussion_r488191271
##########
File path: geode-redis/src/main/java/org/apache/geode/redis/internal/RedisStats.java
##########
@@ -177,6 +177,10 @@ public void removeClient() {
stats.incLong(clientId, -1);
}
+ public long getClients() {
Review comment:
Just added it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal merged pull request #5510: GEODE-8492: Redis 'clients' statistic goes negative
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal merged pull request #5510:
URL: https://github.com/apache/geode/pull/5510
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5510: GEODE-8492: Redis 'clients' statistic goes negative
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on a change in pull request #5510:
URL: https://github.com/apache/geode/pull/5510#discussion_r488188475
##########
File path: geode-redis/src/main/java/org/apache/geode/redis/internal/RedisStats.java
##########
@@ -177,6 +177,10 @@ public void removeClient() {
stats.incLong(clientId, -1);
}
+ public long getClients() {
Review comment:
add visible for testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org