You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ambari.apache.org by "gvijay452 (via GitHub)" <gi...@apache.org> on 2025/06/16 11:21:13 UTC

[PR] AMBARI-26517 : Avoid printing password during DB connection check [ambari]

gvijay452 opened a new pull request, #4025:
URL: https://github.com/apache/ambari/pull/4025

   ## What changes were proposed in this pull request?
   check_host class uses shlex.split to sanitise the user input. When db_connection_check_command is sanitised, mask password property is lost. 
   
   Proposed:
   We don't need to print the command when running the check. Incase of connection error, Appropriate error will get printed without password
   
   
   ## How was this patch tested?
   Before Fix
   ![before_fix](https://github.com/user-attachments/assets/e41fdbae-2717-45ae-8af8-6015f17887f7)
   
   After Fix
   ![after_fix](https://github.com/user-attachments/assets/5c0f8dfd-eb5d-4e65-b5a9-c7c5b5b0f924)
   
   
   Please review [Ambari Contributing Guide](https://cwiki.apache.org/confluence/display/AMBARI/How+to+Contribute) before opening a pull request.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org

Re: [PR] AMBARI-26517 : Avoid printing password during DB connection check [ambari]

Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.

JiaLiangC merged PR #4025:
URL: https://github.com/apache/ambari/pull/4025


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org

Re: [PR] AMBARI-26517 : Avoid printing password during DB connection check [ambari]

Posted by "JiaLiangC (via GitHub)" <gi...@apache.org>.

JiaLiangC commented on PR #4025:
URL: https://github.com/apache/ambari/pull/4025#issuecomment-3021334771

   @develop-vijay Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org