You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Navina Ramesh <nr...@linkedin.com> on 2015/03/18 02:23:54 UTC
Review Request 32188: Disable WAL in RocksDB KV store
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32188/
-----------------------------------------------------------
Review request for samza.
Repository: samza
Description
-------
Adding KV write performance test
Diffs
-----
samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStorageEngineFactory.scala 14eeba5e7569ebd7f9096b0b8f30117e4fe3434b
samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala eae2a5af665e5da1cf007ee39ee5a79e558f11d6
samza-test/src/main/config/perf/kv-perf.properties 0d487b171cedf017a8711675af7bc5bfb0d029df
samza-test/src/main/scala/org/apache/samza/test/performance/TestKeyValuePerformance.scala b4fa7d3575e3b81ea3b606a1de8f06cedb87168a
Diff: https://reviews.apache.org/r/32188/diff/
Testing
-------
Thanks,
Navina Ramesh
Re: Review Request 32188: Disable WAL in RocksDB KV store
Posted by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32188/#review76989
-----------------------------------------------------------
Ship it!
Ship It!
- Yi Pan (Data Infrastructure)
On March 18, 2015, 11:01 p.m., Navina Ramesh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32188/
> -----------------------------------------------------------
>
> (Updated March 18, 2015, 11:01 p.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> Adding KV write performance test
>
>
> Diffs
> -----
>
> samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStorageEngineFactory.scala 14eeba5e7569ebd7f9096b0b8f30117e4fe3434b
> samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala eae2a5af665e5da1cf007ee39ee5a79e558f11d6
> samza-test/src/main/config/perf/kv-perf.properties 0d487b171cedf017a8711675af7bc5bfb0d029df
> samza-test/src/main/scala/org/apache/samza/test/performance/TestKeyValuePerformance.scala b4fa7d3575e3b81ea3b606a1de8f06cedb87168a
>
> Diff: https://reviews.apache.org/r/32188/diff/
>
>
> Testing
> -------
>
> ./bin/check-all.sh ran successfully on MAC
>
>
> Thanks,
>
> Navina Ramesh
>
>
Re: Review Request 32188: Disable WAL in RocksDB KV store
Posted by Navina Ramesh <nr...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32188/
-----------------------------------------------------------
(Updated March 18, 2015, 11:01 p.m.)
Review request for samza.
Repository: samza
Description
-------
Adding KV write performance test
Diffs (updated)
-----
samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStorageEngineFactory.scala 14eeba5e7569ebd7f9096b0b8f30117e4fe3434b
samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala eae2a5af665e5da1cf007ee39ee5a79e558f11d6
samza-test/src/main/config/perf/kv-perf.properties 0d487b171cedf017a8711675af7bc5bfb0d029df
samza-test/src/main/scala/org/apache/samza/test/performance/TestKeyValuePerformance.scala b4fa7d3575e3b81ea3b606a1de8f06cedb87168a
Diff: https://reviews.apache.org/r/32188/diff/
Testing
-------
./bin/check-all.sh ran successfully on MAC
Thanks,
Navina Ramesh
Re: Review Request 32188: Disable WAL in RocksDB KV store
Posted by Navina Ramesh <nr...@linkedin.com>.
> On March 18, 2015, 9:56 p.m., Yi Pan (Data Infrastructure) wrote:
> > samza-test/src/main/scala/org/apache/samza/test/performance/TestKeyValuePerformance.scala, line 135
> > <https://reviews.apache.org/r/32188/diff/1/?file=898491#file898491line135>
> >
> > nit: do we need multiple instances of ByteSerde here?
Ah..not really. Will change that.
- Navina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32188/#review76954
-----------------------------------------------------------
On March 18, 2015, 9:48 p.m., Navina Ramesh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32188/
> -----------------------------------------------------------
>
> (Updated March 18, 2015, 9:48 p.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> Adding KV write performance test
>
>
> Diffs
> -----
>
> samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStorageEngineFactory.scala 14eeba5e7569ebd7f9096b0b8f30117e4fe3434b
> samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala eae2a5af665e5da1cf007ee39ee5a79e558f11d6
> samza-test/src/main/config/perf/kv-perf.properties 0d487b171cedf017a8711675af7bc5bfb0d029df
> samza-test/src/main/scala/org/apache/samza/test/performance/TestKeyValuePerformance.scala b4fa7d3575e3b81ea3b606a1de8f06cedb87168a
>
> Diff: https://reviews.apache.org/r/32188/diff/
>
>
> Testing
> -------
>
> ./bin/check-all.sh ran successfully on MAC
>
>
> Thanks,
>
> Navina Ramesh
>
>
Re: Review Request 32188: Disable WAL in RocksDB KV store
Posted by "Yi Pan (Data Infrastructure)" <yi...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32188/#review76954
-----------------------------------------------------------
Overall looks good to me.
samza-test/src/main/scala/org/apache/samza/test/performance/TestKeyValuePerformance.scala
<https://reviews.apache.org/r/32188/#comment124695>
nit: do we need multiple instances of ByteSerde here?
- Yi Pan (Data Infrastructure)
On March 18, 2015, 9:48 p.m., Navina Ramesh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32188/
> -----------------------------------------------------------
>
> (Updated March 18, 2015, 9:48 p.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> Adding KV write performance test
>
>
> Diffs
> -----
>
> samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStorageEngineFactory.scala 14eeba5e7569ebd7f9096b0b8f30117e4fe3434b
> samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala eae2a5af665e5da1cf007ee39ee5a79e558f11d6
> samza-test/src/main/config/perf/kv-perf.properties 0d487b171cedf017a8711675af7bc5bfb0d029df
> samza-test/src/main/scala/org/apache/samza/test/performance/TestKeyValuePerformance.scala b4fa7d3575e3b81ea3b606a1de8f06cedb87168a
>
> Diff: https://reviews.apache.org/r/32188/diff/
>
>
> Testing
> -------
>
> ./bin/check-all.sh ran successfully on MAC
>
>
> Thanks,
>
> Navina Ramesh
>
>
Re: Review Request 32188: Disable WAL in RocksDB KV store
Posted by Navina Ramesh <nr...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32188/
-----------------------------------------------------------
(Updated March 18, 2015, 9:48 p.m.)
Review request for samza.
Repository: samza
Description
-------
Adding KV write performance test
Diffs
-----
samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStorageEngineFactory.scala 14eeba5e7569ebd7f9096b0b8f30117e4fe3434b
samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala eae2a5af665e5da1cf007ee39ee5a79e558f11d6
samza-test/src/main/config/perf/kv-perf.properties 0d487b171cedf017a8711675af7bc5bfb0d029df
samza-test/src/main/scala/org/apache/samza/test/performance/TestKeyValuePerformance.scala b4fa7d3575e3b81ea3b606a1de8f06cedb87168a
Diff: https://reviews.apache.org/r/32188/diff/
Testing (updated)
-------
./bin/check-all.sh ran successfully on MAC
Thanks,
Navina Ramesh