You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/13 18:23:08 UTC

[GitHub] [superset] rusackas commented on pull request #12423: fix: incorrect cursor position Firefox

rusackas commented on pull request #12423:
URL: https://github.com/apache/superset/pull/12423#issuecomment-759632469


   Ugh... not again! ACE Editor is so painful with this issue, it seems to keep popping up like whack-a-mole. My general _feelings_ on the issue are:
   * I'd hate to see Fira Code die off due to this bug (but I understand)
   * I fear if we use other platform-specific fonts (Menlo, etc) we'll see this continue to manifest itself in other ways.
   * I hope we can target altering just the bold words as Elizabeth suggests.
   
   The way it calculates the position is just super error prone... I'm not sure if something like CodeMirror has all the features we need, but my temptation to dive into that rabbit hole is growing.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org