You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Hoss Man (JIRA)" <ji...@apache.org> on 2008/09/03 02:41:44 UTC

[jira] Created: (SOLR-749) QParser and ValueSourceParser init bug

QParser and ValueSourceParser init bug
--------------------------------------

                 Key: SOLR-749
                 URL: https://issues.apache.org/jira/browse/SOLR-749
             Project: Solr
          Issue Type: Bug
          Components: search
    Affects Versions: 1.3
            Reporter: Hoss Man
             Fix For: 1.3


As noticed by Maximilian Hütter in this email thread...

http://www.nabble.com/SOLR-218-problem-to19266169.html#a19266169

...when a person tries to register a QParser (or ValueSourceParser) with the same name as a "standard" implementation it gets blown away by the initialization code for the standard impls.

we need to allow people to override these standard names the same way they can with responseWriters, etc...



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-749) QParser and ValueSourceParser init bug

Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627984#action_12627984 ] 

Grant Ingersoll commented on SOLR-749:
--------------------------------------

I think we need a test case for this.

> QParser and ValueSourceParser init bug
> --------------------------------------
>
>                 Key: SOLR-749
>                 URL: https://issues.apache.org/jira/browse/SOLR-749
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Hoss Man
>             Fix For: 1.3
>
>         Attachments: SOLR-749.patch
>
>
> As noticed by Maximilian Hütter in this email thread...
> http://www.nabble.com/SOLR-218-problem-to19266169.html#a19266169
> ...when a person tries to register a QParser (or ValueSourceParser) with the same name as a "standard" implementation it gets blown away by the initialization code for the standard impls.
> we need to allow people to override these standard names the same way they can with responseWriters, etc...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SOLR-749) QParser and ValueSourceParser init bug

Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll resolved SOLR-749.
----------------------------------

    Resolution: Fixed

Committed on trunk and on branch-1.3

> QParser and ValueSourceParser init bug
> --------------------------------------
>
>                 Key: SOLR-749
>                 URL: https://issues.apache.org/jira/browse/SOLR-749
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Hoss Man
>            Assignee: Grant Ingersoll
>             Fix For: 1.3
>
>         Attachments: SOLR-749.patch, SOLR-749.patch
>
>
> As noticed by Maximilian Hütter in this email thread...
> http://www.nabble.com/SOLR-218-problem-to19266169.html#a19266169
> ...when a person tries to register a QParser (or ValueSourceParser) with the same name as a "standard" implementation it gets blown away by the initialization code for the standard impls.
> we need to allow people to override these standard names the same way they can with responseWriters, etc...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (SOLR-749) QParser and ValueSourceParser init bug

Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll reassigned SOLR-749:
------------------------------------

    Assignee: Grant Ingersoll

> QParser and ValueSourceParser init bug
> --------------------------------------
>
>                 Key: SOLR-749
>                 URL: https://issues.apache.org/jira/browse/SOLR-749
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Hoss Man
>            Assignee: Grant Ingersoll
>             Fix For: 1.3
>
>         Attachments: SOLR-749.patch
>
>
> As noticed by Maximilian Hütter in this email thread...
> http://www.nabble.com/SOLR-218-problem-to19266169.html#a19266169
> ...when a person tries to register a QParser (or ValueSourceParser) with the same name as a "standard" implementation it gets blown away by the initialization code for the standard impls.
> we need to allow people to override these standard names the same way they can with responseWriters, etc...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-749) QParser and ValueSourceParser init bug

Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man updated SOLR-749:
--------------------------

    Attachment: SOLR-749.patch

To clarify: I *think* this a bug based on a quick skim of the code (i only caught the ValueSourceParser part because i greped for init(null)) but i'm not 100% certain.  I'd appreciate some verification from someone else.

Assuming i'm right, here's a quick patch (untested)

> QParser and ValueSourceParser init bug
> --------------------------------------
>
>                 Key: SOLR-749
>                 URL: https://issues.apache.org/jira/browse/SOLR-749
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Hoss Man
>             Fix For: 1.3
>
>         Attachments: SOLR-749.patch
>
>
> As noticed by Maximilian Hütter in this email thread...
> http://www.nabble.com/SOLR-218-problem-to19266169.html#a19266169
> ...when a person tries to register a QParser (or ValueSourceParser) with the same name as a "standard" implementation it gets blown away by the initialization code for the standard impls.
> we need to allow people to override these standard names the same way they can with responseWriters, etc...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-749) QParser and ValueSourceParser init bug

Posted by "Grant Ingersoll (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Grant Ingersoll updated SOLR-749:
---------------------------------

    Attachment: SOLR-749.patch

Hoss's patch plus unit tests

> QParser and ValueSourceParser init bug
> --------------------------------------
>
>                 Key: SOLR-749
>                 URL: https://issues.apache.org/jira/browse/SOLR-749
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Hoss Man
>            Assignee: Grant Ingersoll
>             Fix For: 1.3
>
>         Attachments: SOLR-749.patch, SOLR-749.patch
>
>
> As noticed by Maximilian Hütter in this email thread...
> http://www.nabble.com/SOLR-218-problem-to19266169.html#a19266169
> ...when a person tries to register a QParser (or ValueSourceParser) with the same name as a "standard" implementation it gets blown away by the initialization code for the standard impls.
> we need to allow people to override these standard names the same way they can with responseWriters, etc...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SOLR-749) QParser and ValueSourceParser init bug

Posted by "Yonik Seeley (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12627884#action_12627884 ] 

Yonik Seeley commented on SOLR-749:
-----------------------------------

So... standard plugins are only created/registered if it's name doesn't already exist.  The logic seems fine, but I haven't tested it either ;-)

> QParser and ValueSourceParser init bug
> --------------------------------------
>
>                 Key: SOLR-749
>                 URL: https://issues.apache.org/jira/browse/SOLR-749
>             Project: Solr
>          Issue Type: Bug
>          Components: search
>    Affects Versions: 1.3
>            Reporter: Hoss Man
>             Fix For: 1.3
>
>         Attachments: SOLR-749.patch
>
>
> As noticed by Maximilian Hütter in this email thread...
> http://www.nabble.com/SOLR-218-problem-to19266169.html#a19266169
> ...when a person tries to register a QParser (or ValueSourceParser) with the same name as a "standard" implementation it gets blown away by the initialization code for the standard impls.
> we need to allow people to override these standard names the same way they can with responseWriters, etc...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.