You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/08 04:25:54 UTC

[GitHub] [spark] HeartSaVioR commented on a diff in pull request #38898: [SPARK-41375][SS] Avoid empty latest KafkaSourceOffset

HeartSaVioR commented on code in PR #38898:
URL: https://github.com/apache/spark/pull/38898#discussion_r1042910210


##########
connector/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchSourceSuite.scala:
##########
@@ -627,6 +627,45 @@ abstract class KafkaMicroBatchSourceSuiteBase extends KafkaSourceSuiteBase {
     )
   }
 
+  test("SPARK-41375: empty partitions should not record to latest offset") {
+    val topicPrefix = newTopic()

Review Comment:
   Please set `spark.sql.streaming.kafka.useDeprecatedOffsetFetching` to `true`. You can do this with leveraging `withSQLConf(...map of explicit config here...) { ...test code here... }`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org