You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/28 03:39:16 UTC
[GitHub] [flink] fredia opened a new pull request, #21405: [FLINK-23035][state/changelog] Add explicit append() to StateChangelogWriter to write metadata
fredia opened a new pull request, #21405:
URL: https://github.com/apache/flink/pull/21405
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Add explicit append() to StateChangelogWriter to write metadata.
## Brief change log
- Add explicit `StateChange(byte[] value)`
- Add explicit `append(byte[] value)`
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fredia commented on pull request #21405: [FLINK-23035][state/changelog] Add explicit append() to StateChangelogWriter to write metadata
Posted by GitBox <gi...@apache.org>.
fredia commented on PR #21405:
URL: https://github.com/apache/flink/pull/21405#issuecomment-1345160608
@rkhachatryan Thanks for reviewing.
> 1. Have you considered splitting StateChange class into StateChange and StateChange?
I splited the constructor of StateChange into `StateChange(byte[])` and `StateChange(int keyGroup, byte[])`, as you suggested, I add `ofMetadataChange(byte[])` and `ofDataChange(int keyGroup, byte[]))` factory methods.
> 2. In [StateChangeFormat.writeChangeSet](https://github.com/apache/flink/blob/master/flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/StateChangeFormat.java#L66), the metadata can now be written out explicitly, rather than relying on sorting.
👍Good catch, this can avoid the overhead of sorting, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fredia commented on pull request #21405: [FLINK-23035][state/changelog] Add explicit append() to StateChangelogWriter to write metadata
Posted by GitBox <gi...@apache.org>.
fredia commented on PR #21405:
URL: https://github.com/apache/flink/pull/21405#issuecomment-1331735494
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #21405: [FLINK-23035][state/changelog] Add explicit append() to StateChangelogWriter to write metadata
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21405:
URL: https://github.com/apache/flink/pull/21405#issuecomment-1328493977
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fdc39492b315dbecc5b4cff8f222caa53eebee87",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fdc39492b315dbecc5b4cff8f222caa53eebee87",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fdc39492b315dbecc5b4cff8f222caa53eebee87 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on pull request #21405: [FLINK-23035][state/changelog] Add explicit append() to StateChangelogWriter to write metadata
Posted by GitBox <gi...@apache.org>.
curcur commented on PR #21405:
URL: https://github.com/apache/flink/pull/21405#issuecomment-1340413916
> @curcur Thanks a lot for reviewing, I addressed the comments, please take a look again. And I'd squash those commits if it's OK for you.
Thanks @fredia LGTM, I've ACC it. Please squash it and I can merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur merged pull request #21405: [FLINK-23035][state/changelog] Add explicit append() to StateChangelogWriter to write metadata
Posted by GitBox <gi...@apache.org>.
curcur merged PR #21405:
URL: https://github.com/apache/flink/pull/21405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fredia commented on pull request #21405: [FLINK-23035][state/changelog] Add explicit append() to StateChangelogWriter to write metadata
Posted by GitBox <gi...@apache.org>.
fredia commented on PR #21405:
URL: https://github.com/apache/flink/pull/21405#issuecomment-1341890756
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fredia commented on pull request #21405: [FLINK-23035][state/changelog] Add explicit append() to StateChangelogWriter to write metadata
Posted by GitBox <gi...@apache.org>.
fredia commented on PR #21405:
URL: https://github.com/apache/flink/pull/21405#issuecomment-1333055009
@masteryhx Thanks a lot for reviewing, @rkhachatryan would you like to take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fredia commented on pull request #21405: [FLINK-23035][state/changelog] Add explicit append() to StateChangelogWriter to write metadata
Posted by GitBox <gi...@apache.org>.
fredia commented on PR #21405:
URL: https://github.com/apache/flink/pull/21405#issuecomment-1340407855
@curcur Thanks a lot for reviewing, I addressed the comments, please take a look again.
And I'd squash those commits if it's OK for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fredia commented on pull request #21405: [FLINK-23035][state/changelog] Add explicit append() to StateChangelogWriter to write metadata
Posted by GitBox <gi...@apache.org>.
fredia commented on PR #21405:
URL: https://github.com/apache/flink/pull/21405#issuecomment-1354142422
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fredia commented on a diff in pull request #21405: [FLINK-23035][state/changelog] Add explicit append() to StateChangelogWriter to write metadata
Posted by GitBox <gi...@apache.org>.
fredia commented on code in PR #21405:
URL: https://github.com/apache/flink/pull/21405#discussion_r1044999240
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/StateChange.java:
##########
@@ -26,14 +26,21 @@
@Internal
public class StateChange implements Serializable {
+ /* For metadata, see FLINK-23035.*/
+ public static final int META_KEY_GROUP = -1;
+
private static final long serialVersionUID = 1L;
private final int keyGroup;
private final byte[] change;
+ public StateChange(byte[] change) {
+ this.keyGroup = META_KEY_GROUP;
+ this.change = Preconditions.checkNotNull(change);
+ }
+
public StateChange(int keyGroup, byte[] change) {
- // todo: enable check in FLINK-23035
- // Preconditions.checkArgument(keyGroup >= 0);
+ Preconditions.checkArgument(keyGroup >= 0);
Review Comment:
Nice suggestion, this can reduce the probability of error, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rkhachatryan commented on a diff in pull request #21405: [FLINK-23035][state/changelog] Add explicit append() to StateChangelogWriter to write metadata
Posted by GitBox <gi...@apache.org>.
rkhachatryan commented on code in PR #21405:
URL: https://github.com/apache/flink/pull/21405#discussion_r1043827297
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/StateChange.java:
##########
@@ -26,14 +26,21 @@
@Internal
public class StateChange implements Serializable {
+ /* For metadata, see FLINK-23035.*/
+ public static final int META_KEY_GROUP = -1;
+
private static final long serialVersionUID = 1L;
private final int keyGroup;
private final byte[] change;
+ public StateChange(byte[] change) {
+ this.keyGroup = META_KEY_GROUP;
+ this.change = Preconditions.checkNotNull(change);
+ }
+
public StateChange(int keyGroup, byte[] change) {
- // todo: enable check in FLINK-23035
- // Preconditions.checkArgument(keyGroup >= 0);
+ Preconditions.checkArgument(keyGroup >= 0);
Review Comment:
I think choosing the right constructor is a bit confusing and error-prone now.
WDYT about making both constructors private and providing clearly named factory methods (e.g. `ofMetadataChange(byte[])` and `ofDataChange(int keyGroup, byte[])`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] curcur commented on a diff in pull request #21405: [FLINK-23035][state/changelog] Add explicit append() to StateChangelogWriter to write metadata
Posted by GitBox <gi...@apache.org>.
curcur commented on code in PR #21405:
URL: https://github.com/apache/flink/pull/21405#discussion_r1041764339
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/changelog/StateChange.java:
##########
@@ -26,14 +26,21 @@
@Internal
public class StateChange implements Serializable {
+ /* For metadata, see FLINK-23035.*/
+ public static final int COMMON_KEY_GROUP = -1;
Review Comment:
rename this to META_KEY_GROUP?
##########
flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/FsStateChangelogWriter.java:
##########
@@ -167,6 +167,20 @@ class FsStateChangelogWriter implements StateChangelogWriter<ChangelogStateHandl
this.localChangelogRegistry = localChangelogRegistry;
}
+ @Override
+ public void append(byte[] value) throws IOException {
+ LOG.trace("append metadata to {}: {} bytes", logId, value.length);
+ checkState(!closed, "%s is closed", logId);
+ activeChangeSet.add(new StateChange(value));
+ activeChangeSetSize += value.length;
+ if (activeChangeSetSize >= preEmptivePersistThresholdInBytes) {
+ LOG.debug(
+ "pre-emptively flush {}MB of appended changes to the common store",
+ activeChangeSetSize / 1024 / 1024);
+ persistInternal(notUploaded.isEmpty() ? activeSequenceNumber : notUploaded.firstKey());
+ }
+ }
Review Comment:
There are a lot of duplicate code between the two "append" methods.
Please extract the two common part and rename this to "appendMeta" for example.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org