You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Mesos ReviewBot <de...@mesos.apache.org> on 2014/06/02 08:34:22 UTC
Re: Review Request 21379: First phase: Mesos-slave support for "node drain"
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21379/#review44477
-----------------------------------------------------------
Patch looks great!
Reviews applied: [21379]
All tests passed.
- Mesos ReviewBot
On May 30, 2014, 9:39 p.m., Alexandra Sava wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21379/
> -----------------------------------------------------------
>
> (Updated May 30, 2014, 9:39 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-544
> https://issues.apache.org/jira/browse/MESOS-544
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> First phase: Mesos-slave support for "node drain"
>
> This phase handles the shutdown of the slave, triggered by SIGUSR1 signal:
> * implement a signal handler which is invoked when SIGUSR1 signal is issued
> * the signal handler will dispatch the 'shutdown' method of the Slave class, which shuts down all the frameworks and executors that run on the slave.
>
> In the next phase, the slave will send an unregistration request to the master in order to overcome the lag of the health check timer (75 sec).
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 34687e555e6ba07863c45840aa6d07717388cf62
> src/slave/slave.cpp c5c05132874b581829dfd191b8a553971fb8f3df
>
> Diff: https://reviews.apache.org/r/21379/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexandra Sava
>
>