You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/05/23 18:42:30 UTC

[GitHub] [netbeans] lkishalmi opened a new pull request #2154: [NETBEANS-4365] Fix NetBeans New Action Wizard.

lkishalmi opened a new pull request #2154:
URL: https://github.com/apache/netbeans/pull/2154


   The new freemarker seems to be do a serialize/unserialize phase when processing parameters map. The original implementation put a non serializable inner class wrapped into a proxy eventually caused that a collection contained a proxy class which referenced a null object.
   
   This solution is simply replace that kind of "smart" way to pass Java annotation value object around by creating an actual serializable model class instead.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] lkishalmi commented on pull request #2154: [NETBEANS-4365] Fix NetBeans New Action Wizard.

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2154:
URL: https://github.com/apache/netbeans/pull/2154#issuecomment-633115181


   I've checked the NetBeans API Wizard sources for similar "smart" solution and found no other occurances.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] ebarboni merged pull request #2154: [NETBEANS-4365] Fix NetBeans New Action Wizard.

Posted by GitBox <gi...@apache.org>.
ebarboni merged pull request #2154:
URL: https://github.com/apache/netbeans/pull/2154


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] neilcsmith-net commented on pull request #2154: [NETBEANS-4365] Fix NetBeans New Action Wizard.

Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #2154:
URL: https://github.com/apache/netbeans/pull/2154#issuecomment-633511333


   Not sure this is a reason to hold up 12.0 release, but perhaps we need to bring back / introduce a `Cherry Pick` / `Backport` label for critical fixes that we want to include in a 12.0 update once they've reached master?
   
   Also maybe @JaroslavTulach might want to review this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] geertjanw commented on pull request #2154: [NETBEANS-4365] Fix NetBeans New Action Wizard.

Posted by GitBox <gi...@apache.org>.
geertjanw commented on pull request #2154:
URL: https://github.com/apache/netbeans/pull/2154#issuecomment-633512940


   Sounds silly, maybe, but via this problem we'll be able to see who's actually using the NetBeans Platform, from scratch -- i.e., we know what the problem is here and can help anyone immediately as soon as they encounter this, we'll list it in the release notes, etc, though by not fixing it (unless we need another Beta for other reasons), this could be a way to see what kind of new development is done with the NetBeans Platform, since a newbie is likely to encounter this within the 1st hours of using the NetBeans Platform...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


[GitHub] [netbeans] lkishalmi commented on pull request #2154: [NETBEANS-4365] Fix NetBeans New Action Wizard.

Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2154:
URL: https://github.com/apache/netbeans/pull/2154#issuecomment-633653814


   Well, I removed the 12.0 milestone. This would be a candidate for 12.0.1 patch release if we would do such things.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists