You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2015/07/30 20:07:19 UTC

[GitHub] flink pull request: [FLINK-2431] Refactor PlanBinder/OperationInfo

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/961

    [FLINK-2431] Refactor PlanBinder/OperationInfo

    PlanBinder methods were restructured to make the class more readable.
    
    Keys are now stored as strings to simplify string-key-expression support.
    Parameter retrieval was moved from PlanBinder to OperationInfo constructor, similiar to PythonOperationInfo.
    This change reduces the clutter in Planbinder and allows code re-usage for operations with similar parameters.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 2431_pr

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/961.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #961
    
----
commit 908151add9f411309042c11091981dd577a3282d
Author: zentol <s....@web.de>
Date:   2015-07-30T09:18:35Z

    [FLINK-2431] Refactor PlanBinder/OperationInfo
    
    PlanBinder methods were restructured to make the class more readable.
    
    Keys are now stored as strings to simplify string-key-expression support.
    Parameter retrieval was moved from PB to OI constructor, similiar to PythonOperationInfo.
    This change reduces the clutter in Planbinder and allows code reusage for operations with similar parameters.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2431] Refactor PlanBinder/OperationInfo

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/961#issuecomment-131167834
  
    Will merge this...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2431] Refactor PlanBinder/OperationInfo

Posted by mxm <gi...@git.apache.org>.

Github user mxm commented on the pull request:

    https://github.com/apache/flink/pull/961#issuecomment-128298588
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-2431] Refactor PlanBinder/OperationInfo

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/961


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---