You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/11/20 16:44:00 UTC
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request
#8614: SHA display touchups
dpgaspar commented on a change in pull request #8614: SHA display touchups
URL: https://github.com/apache/incubator-superset/pull/8614#discussion_r348617660
##########
File path: superset/config.py
##########
@@ -70,7 +70,7 @@ def _try_json_readversion(filepath):
def _try_json_readsha(filepath):
try:
with open(filepath, "r") as f:
- return json.load(f).get("GIT_SHA")
+ return json.load(f).get("GIT_SHA")[-8:]
Review comment:
I would prefer the first 8 chars `[:8]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org