[GitHub] [arrow] nealrichardson commented on a diff in pull request #14281: ARROW-17387: [R] Implement dplyr::across() inside filter()

[GitBox <gi...@apache.org>]

nealrichardson commented on code in PR #14281:
URL: https://github.com/apache/arrow/pull/14281#discussion_r984480770


##########
r/R/dplyr-across.R:
##########
@@ -23,7 +23,7 @@ expand_across <- function(.data, quos_in) {
     quo_expr <- quo_get_expr(quo_in[[1]])
     quo_env <- quo_get_env(quo_in[[1]])
 
-    if (is_call(quo_expr, "across")) {
+    if (is_call(quo_expr, c("across", "if_any", "if_all"))) {

Review Comment:
   Be sure to update docgen.R to reflect what is supported in `across()` now. You may also want to add entries there for `if_any` and `if_all` (they're tidyselect?) since they're supported too but not automatically included in the docs since they don't go through `register_binding`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org