You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2019/04/01 23:57:35 UTC

Review Request 70352: Added roles::ancestors for walking up the role hierarchy.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70352/
-----------------------------------------------------------

Review request for mesos and Meng Zhu.


Repository: mesos


Description
-------

See summary.


Diffs
-----

  include/mesos/roles.hpp 45a45c5ff8fafedde09975009442e86861d22725 
  src/common/roles.cpp 649d4695f63166eb1ebda879c55259553c0e8663 
  src/tests/role_tests.cpp a609ed27ef828ca82efc0d269669cda92e5f50a1 


Diff: https://reviews.apache.org/r/70352/diff/1/


Testing
-------

Added a test.


Thanks,

Benjamin Mahler

Re: Review Request 70352: Added roles::ancestors for walking up the role hierarchy.

Posted by Meng Zhu <mz...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70352/#review214249
-----------------------------------------------------------


Ship it!




Ship It!

- Meng Zhu


On April 1, 2019, 4:57 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70352/
> -----------------------------------------------------------
> 
> (Updated April 1, 2019, 4:57 p.m.)
> 
> 
> Review request for mesos and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/roles.hpp 45a45c5ff8fafedde09975009442e86861d22725 
>   src/common/roles.cpp 649d4695f63166eb1ebda879c55259553c0e8663 
>   src/tests/role_tests.cpp a609ed27ef828ca82efc0d269669cda92e5f50a1 
> 
> 
> Diff: https://reviews.apache.org/r/70352/diff/1/
> 
> 
> Testing
> -------
> 
> Added a test.
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>