You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/03/27 06:13:16 UTC
[GitHub] [incubator-openwhisk] codecov-io commented on issue #4392: Enable
attachment reads from CloudFront
codecov-io commented on issue #4392: Enable attachment reads from CloudFront
URL: https://github.com/apache/incubator-openwhisk/pull/4392#issuecomment-476993284
# [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4392?src=pr&el=h1) Report
> Merging [#4392](https://codecov.io/gh/apache/incubator-openwhisk/pull/4392?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/29d0d5d922d13e662c20b6bec129ade6d30d0140?src=pr&el=desc) will **decrease** coverage by `4.67%`.
> The diff coverage is `62.85%`.
[](https://codecov.io/gh/apache/incubator-openwhisk/pull/4392?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4392 +/- ##
==========================================
- Coverage 85.52% 80.84% -4.68%
==========================================
Files 169 170 +1
Lines 7873 7900 +27
Branches 543 542 -1
==========================================
- Hits 6733 6387 -346
- Misses 1140 1513 +373
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/4392?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...openwhisk/core/database/s3/S3AttachmentStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4392/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvczMvUzNBdHRhY2htZW50U3RvcmUuc2NhbGE=) | `76% <55.55%> (-9.72%)` | :arrow_down: |
| [.../openwhisk/core/database/s3/CloudFrontSigner.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4392/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvczMvQ2xvdWRGcm9udFNpZ25lci5zY2FsYQ==) | `87.5% <87.5%> (ø)` | |
| [...core/database/cosmosdb/RxObservableImplicits.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4392/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvUnhPYnNlcnZhYmxlSW1wbGljaXRzLnNjYWxh) | `0% <0%> (-100%)` | :arrow_down: |
| [...core/database/cosmosdb/CosmosDBArtifactStore.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4392/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlLnNjYWxh) | `0% <0%> (-95.46%)` | :arrow_down: |
| [...sk/core/database/cosmosdb/CosmosDBViewMapper.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4392/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJWaWV3TWFwcGVyLnNjYWxh) | `0% <0%> (-92.67%)` | :arrow_down: |
| [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4392/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (-84.62%)` | :arrow_down: |
| [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4392/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `4% <0%> (-52%)` | :arrow_down: |
| [...in/scala/org/apache/openwhisk/common/Counter.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4392/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9Db3VudGVyLnNjYWxh) | `40% <0%> (-20%)` | :arrow_down: |
| [...penwhisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4392/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `81.81% <0%> (-15.16%)` | :arrow_down: |
| [...nwhisk/core/database/cosmosdb/CosmosDBConfig.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4392/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJDb25maWcuc2NhbGE=) | `94.11% <0%> (-5.89%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/4392/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4392?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4392?src=pr&el=footer). Last update [29d0d5d...0cb1c2b](https://codecov.io/gh/apache/incubator-openwhisk/pull/4392?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services