You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "wu-sheng (via GitHub)" <gi...@apache.org> on 2026/04/16 07:11:23 UTC

[PR] fix: disable Ryuk reaper when cleanup.on is never [skywalking-infra-e2e]

wu-sheng opened a new pull request, #147:
URL: https://github.com/apache/skywalking-infra-e2e/pull/147

   ## Summary
   
   - After migrating to testcontainers-go (#146), the Ryuk reaper sidecar automatically removes all containers when the e2e process exits, making `cleanup.on: never` ineffective in compose mode
   - Fix: disable Ryuk by setting `TESTCONTAINERS_RYUK_DISABLED=true` before creating the compose stack when `cleanup.on` is configured as `never`
   
   ## Test plan
   
   - [x] Verified locally with a Docker Compose e2e config using `cleanup.on: never` — containers now survive after process exit
   - [x] Verified Ryuk is no longer started when `cleanup.on: never`
   - [x] Lint and unit tests pass (`make lint && make test`)
   
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix: disable Ryuk reaper when cleanup.on is never [skywalking-infra-e2e]

Posted by "wankai123 (via GitHub)" <gi...@apache.org>.
wankai123 merged PR #147:
URL: https://github.com/apache/skywalking-infra-e2e/pull/147


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org