You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/01/29 01:28:27 UTC

[GitHub] [tvm] jwfromm commented on pull request #7366: [TVMC] Allow manual shape specification in tvmc

jwfromm commented on pull request #7366:
URL: https://github.com/apache/tvm/pull/7366#issuecomment-769510961


   Funny that these two very similar PRs landed so close to one another. After reading both, I would argue in favor of choosing this implementation. I think its important to be able to specify a mapping between input name and shape. Not only is this important for constructing a shape dictionary for all non-pytorch frontends, but it also allows a subset of shapes to be overwritten. If a bert model for example had 4 default shapes, this approach would allow us to specify `seq_len=[256]` while leaving the other 3 shapes alone.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org