[GitHub] [iceberg] rdblue commented on pull request #1271: Align the records written by GenericOrcWriter and SparkOrcWriter

[GitBox <gi...@apache.org>]

rdblue commented on pull request #1271:
URL: https://github.com/apache/iceberg/pull/1271#issuecomment-669522605


   This looks good to me, except that we need to update the test to validate against the original in-memory records, not against a set that was read from a file. It would also be good to have a test that specifically exercises the decimal path, or increase the number of random records until we are confident that one decimal will have one or more trailing 0s.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org