You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Yan Zhou (JIRA)" <ji...@apache.org> on 2010/12/17 19:20:01 UTC
[jira] Created: (PIG-1775) Removal of old logical plan
Removal of old logical plan
---------------------------
Key: PIG-1775
URL: https://issues.apache.org/jira/browse/PIG-1775
Project: Pig
Issue Type: Improvement
Affects Versions: 0.9.0
Reporter: Yan Zhou
Fix For: 0.9.0
The new logical plan will only be used and the old logical plan will be removed once the new one is stable enough. It is scheduled for the 0.9 release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-1775) Removal of old logical plan
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich updated PIG-1775:
--------------------------------
Assignee: Daniel Dai
Daniel, is there any work remains here other than removing the code itself?
> Removal of old logical plan
> ---------------------------
>
> Key: PIG-1775
> URL: https://issues.apache.org/jira/browse/PIG-1775
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Yan Zhou
> Assignee: Daniel Dai
> Fix For: 0.9.0
>
>
> The new logical plan will only be used and the old logical plan will be removed once the new one is stable enough. It is scheduled for the 0.9 release.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1775) Removal of old logical plan
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027710#comment-13027710 ]
Xuefu Zhang commented on PIG-1775:
----------------------------------
This ticket is not about logical plan replacement, which has already happened, but it's about migrating those test cases that are based on the old logical plan. Of course, dead code will be removed accordingly.
> Removal of old logical plan
> ---------------------------
>
> Key: PIG-1775
> URL: https://issues.apache.org/jira/browse/PIG-1775
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Yan Zhou
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: PIG-1775.patch
>
>
> The new logical plan will only be used and the old logical plan will be removed once the new one is stable enough. It is scheduled for the 0.9 release.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (PIG-1775) Removal of old logical plan
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai reassigned PIG-1775:
-------------------------------
Assignee: Xuefu Zhang (was: Daniel Dai)
> Removal of old logical plan
> ---------------------------
>
> Key: PIG-1775
> URL: https://issues.apache.org/jira/browse/PIG-1775
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Yan Zhou
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
>
> The new logical plan will only be used and the old logical plan will be removed once the new one is stable enough. It is scheduled for the 0.9 release.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1775) Removal of old logical plan
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030184#comment-13030184 ]
Daniel Dai commented on PIG-1775:
---------------------------------
We also need to remove test entries in test/commit-tests, test/unit-tests. Otherwise looks good.
> Removal of old logical plan
> ---------------------------
>
> Key: PIG-1775
> URL: https://issues.apache.org/jira/browse/PIG-1775
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Yan Zhou
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: PIG-1775-2.patch, PIG-1775-3.patch, PIG-1775-4.patch, PIG-1775-4.patch, PIG-1775.patch, piggybank.patch
>
>
> The new logical plan will only be used and the old logical plan will be removed once the new one is stable enough. It is scheduled for the 0.9 release.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1775) Removal of old logical plan
Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029506#comment-13029506 ]
Thejas M Nair commented on PIG-1775:
------------------------------------
+1
> Removal of old logical plan
> ---------------------------
>
> Key: PIG-1775
> URL: https://issues.apache.org/jira/browse/PIG-1775
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Yan Zhou
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: PIG-1775-2.patch, PIG-1775-3.patch, PIG-1775.patch
>
>
> The new logical plan will only be used and the old logical plan will be removed once the new one is stable enough. It is scheduled for the 0.9 release.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1775) Removal of old logical plan
Posted by "Thejas M Nair (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027943#comment-13027943 ]
Thejas M Nair commented on PIG-1775:
------------------------------------
Comments on - PIG-1775.patch -
TestLogToPhyCompiler.testComplexForeach - this comment can be removed - // Commented out due to PIG-2020
TestMapSideCogroup.testFailure1 - fix for PIG-2018 has been checked in , can this be enabled?
TestLogicalPlanBuilder.testQuery18 - fix for PIG-1996 has been checked in , can this be enabled?
TestLogicalPlanBuilder.testQuery96 - verification part of the test is missing
TestLogicalPlanBuilder.testQuery97 onwards are commented out, should they also be migrated ?
src/org/apache/pig/impl/util/Utils.java - getSchemaFromString has been changed to always return null, should it be re-enabled ?
> Removal of old logical plan
> ---------------------------
>
> Key: PIG-1775
> URL: https://issues.apache.org/jira/browse/PIG-1775
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Yan Zhou
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: PIG-1775.patch
>
>
> The new logical plan will only be used and the old logical plan will be removed once the new one is stable enough. It is scheduled for the 0.9 release.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1775) Removal of old logical plan
Posted by "Jeremy Hanna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027712#comment-13027712 ]
Jeremy Hanna commented on PIG-1775:
-----------------------------------
Right - the ticket is about removing the ability to disable the new logical plan, though. That's what had me a bit concerned. I will do some testing with 0.8.1 as soon as I am able and want to contribute in various ways, such as submitting bugs. However, given the problems NLP has had in the 0.8.x line thus far, it just seemed like a quick removal.
> Removal of old logical plan
> ---------------------------
>
> Key: PIG-1775
> URL: https://issues.apache.org/jira/browse/PIG-1775
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Yan Zhou
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: PIG-1775.patch
>
>
> The new logical plan will only be used and the old logical plan will be removed once the new one is stable enough. It is scheduled for the 0.9 release.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1775) Removal of old logical plan
Posted by "Jeremy Hanna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027716#comment-13027716 ]
Jeremy Hanna commented on PIG-1775:
-----------------------------------
Oh okay - I had misunderstood. Thank you for the clarification. I look forward to using 0.9 in our environment as it comes closer to being released.
> Removal of old logical plan
> ---------------------------
>
> Key: PIG-1775
> URL: https://issues.apache.org/jira/browse/PIG-1775
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Yan Zhou
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: PIG-1775.patch
>
>
> The new logical plan will only be used and the old logical plan will be removed once the new one is stable enough. It is scheduled for the 0.9 release.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-1775) Removal of old logical plan
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xuefu Zhang updated PIG-1775:
-----------------------------
Attachment: PIG-1775-5.patch
Updated patch based on feedback above.
> Removal of old logical plan
> ---------------------------
>
> Key: PIG-1775
> URL: https://issues.apache.org/jira/browse/PIG-1775
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Yan Zhou
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: PIG-1775-2.patch, PIG-1775-3.patch, PIG-1775-4.patch, PIG-1775-4.patch, PIG-1775-5.patch, PIG-1775.patch, piggybank.patch
>
>
> The new logical plan will only be used and the old logical plan will be removed once the new one is stable enough. It is scheduled for the 0.9 release.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-1775) Removal of old logical plan
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xuefu Zhang updated PIG-1775:
-----------------------------
Attachment: PIG-1775-4.patch
Remove obsolete code related to old logical plan. Some test cases are changed as a result.
> Removal of old logical plan
> ---------------------------
>
> Key: PIG-1775
> URL: https://issues.apache.org/jira/browse/PIG-1775
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Yan Zhou
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: PIG-1775-2.patch, PIG-1775-3.patch, PIG-1775-4.patch, PIG-1775.patch
>
>
> The new logical plan will only be used and the old logical plan will be removed once the new one is stable enough. It is scheduled for the 0.9 release.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1775) Removal of old logical plan
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030072#comment-13030072 ]
Xuefu Zhang commented on PIG-1775:
----------------------------------
test-patch run for patch PIG-1775-4.patch:
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 66 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
Unit test also passed.
> Removal of old logical plan
> ---------------------------
>
> Key: PIG-1775
> URL: https://issues.apache.org/jira/browse/PIG-1775
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Yan Zhou
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: PIG-1775-2.patch, PIG-1775-3.patch, PIG-1775-4.patch, PIG-1775-4.patch, PIG-1775.patch, piggybank.patch
>
>
> The new logical plan will only be used and the old logical plan will be removed once the new one is stable enough. It is scheduled for the 0.9 release.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1775) Removal of old logical plan
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030234#comment-13030234 ]
Xuefu Zhang commented on PIG-1775:
----------------------------------
patch PIG-1775-5.patch is committed to both trunk and 0.9.0.
> Removal of old logical plan
> ---------------------------
>
> Key: PIG-1775
> URL: https://issues.apache.org/jira/browse/PIG-1775
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Yan Zhou
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: PIG-1775-2.patch, PIG-1775-3.patch, PIG-1775-4.patch, PIG-1775-4.patch, PIG-1775-5.patch, PIG-1775.patch, piggybank.patch
>
>
> The new logical plan will only be used and the old logical plan will be removed once the new one is stable enough. It is scheduled for the 0.9 release.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-1775) Removal of old logical plan
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1775:
----------------------------
Attachment: nodeprecate.patch
nodeprecate.patch committed to both trunk and 0.9 branch.
> Removal of old logical plan
> ---------------------------
>
> Key: PIG-1775
> URL: https://issues.apache.org/jira/browse/PIG-1775
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Yan Zhou
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: PIG-1775-2.patch, PIG-1775-3.patch, PIG-1775-4.patch, PIG-1775-4.patch, PIG-1775-5.patch, PIG-1775.patch, nodeprecate.patch, piggybank.patch
>
>
> The new logical plan will only be used and the old logical plan will be removed once the new one is stable enough. It is scheduled for the 0.9 release.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1775) Removal of old logical plan
Posted by "Jeremy Hanna (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027333#comment-13027333 ]
Jeremy Hanna commented on PIG-1775:
-----------------------------------
What is the criteria for the new logical plan being stable enough? This ticket kind of scares me as a user of 0.8.0 who has had to disable the new logical plan to get my scripts to work properly. I need to try out 0.8.1 but am currently using cdh3's version of pig, which is 0.8.0 with a handful of patches.
> Removal of old logical plan
> ---------------------------
>
> Key: PIG-1775
> URL: https://issues.apache.org/jira/browse/PIG-1775
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Yan Zhou
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: PIG-1775.patch
>
>
> The new logical plan will only be used and the old logical plan will be removed once the new one is stable enough. It is scheduled for the 0.9 release.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PIG-1775) Removal of old logical plan
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977602#action_12977602 ]
Daniel Dai commented on PIG-1775:
---------------------------------
Mostly in PigServer. It consists of these tasks:
1. Move describe/nested describe to new logical plan
2. Move Graph to new logical plan
3. Move scalar merge to new logical plan
4. Move UnionOnSchemaSetter to new logical plan
5. Remove SortInfoSetter (since it's already in new logical plan)
6. Other cleanup in PigServer
7. Test cases
> Removal of old logical plan
> ---------------------------
>
> Key: PIG-1775
> URL: https://issues.apache.org/jira/browse/PIG-1775
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Yan Zhou
> Fix For: 0.9.0
>
>
> The new logical plan will only be used and the old logical plan will be removed once the new one is stable enough. It is scheduled for the 0.9 release.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Commented] (PIG-1775) Removal of old logical plan
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030230#comment-13030230 ]
Daniel Dai commented on PIG-1775:
---------------------------------
+1
> Removal of old logical plan
> ---------------------------
>
> Key: PIG-1775
> URL: https://issues.apache.org/jira/browse/PIG-1775
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Yan Zhou
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: PIG-1775-2.patch, PIG-1775-3.patch, PIG-1775-4.patch, PIG-1775-4.patch, PIG-1775-5.patch, PIG-1775.patch, piggybank.patch
>
>
> The new logical plan will only be used and the old logical plan will be removed once the new one is stable enough. It is scheduled for the 0.9 release.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-1775) Removal of old logical plan
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xuefu Zhang updated PIG-1775:
-----------------------------
Attachment: PIG-1775.patch
First patch, migrating old test case to use new logical plan. Some obsolete test cases are removed.
> Removal of old logical plan
> ---------------------------
>
> Key: PIG-1775
> URL: https://issues.apache.org/jira/browse/PIG-1775
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Yan Zhou
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: PIG-1775.patch
>
>
> The new logical plan will only be used and the old logical plan will be removed once the new one is stable enough. It is scheduled for the 0.9 release.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-1775) Removal of old logical plan
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xuefu Zhang updated PIG-1775:
-----------------------------
Attachment: PIG-1775-2.patch
Minor update patch. getSchemaFromString() is enabled.
> Removal of old logical plan
> ---------------------------
>
> Key: PIG-1775
> URL: https://issues.apache.org/jira/browse/PIG-1775
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Yan Zhou
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: PIG-1775-2.patch, PIG-1775.patch
>
>
> The new logical plan will only be used and the old logical plan will be removed once the new one is stable enough. It is scheduled for the 0.9 release.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1775) Removal of old logical plan
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13029526#comment-13029526 ]
Xuefu Zhang commented on PIG-1775:
----------------------------------
Test-patch run for patch PIG-1775-3.patch:
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 45 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
Unit test also passed. Patch is committed to both trunk and 0.9.0.
> Removal of old logical plan
> ---------------------------
>
> Key: PIG-1775
> URL: https://issues.apache.org/jira/browse/PIG-1775
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Yan Zhou
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: PIG-1775-2.patch, PIG-1775-3.patch, PIG-1775.patch
>
>
> The new logical plan will only be used and the old logical plan will be removed once the new one is stable enough. It is scheduled for the 0.9 release.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-1775) Removal of old logical plan
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xuefu Zhang updated PIG-1775:
-----------------------------
Attachment: PIG-1775-3.patch
1. Migrated additional test cases
2. Provided new implementation for parsing schema from a string, parsing constant from a string, etc.
> Removal of old logical plan
> ---------------------------
>
> Key: PIG-1775
> URL: https://issues.apache.org/jira/browse/PIG-1775
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Yan Zhou
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: PIG-1775-2.patch, PIG-1775-3.patch, PIG-1775.patch
>
>
> The new logical plan will only be used and the old logical plan will be removed once the new one is stable enough. It is scheduled for the 0.9 release.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1775) Removal of old logical plan
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027184#comment-13027184 ]
Xuefu Zhang commented on PIG-1775:
----------------------------------
Test-patch run:
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 227 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
> Removal of old logical plan
> ---------------------------
>
> Key: PIG-1775
> URL: https://issues.apache.org/jira/browse/PIG-1775
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Yan Zhou
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: PIG-1775.patch
>
>
> The new logical plan will only be used and the old logical plan will be removed once the new one is stable enough. It is scheduled for the 0.9 release.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-1775) Removal of old logical plan
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xuefu Zhang updated PIG-1775:
-----------------------------
Attachment: PIG-1775-4.patch
Updated one test case and correction for some javadoc warnings.
> Removal of old logical plan
> ---------------------------
>
> Key: PIG-1775
> URL: https://issues.apache.org/jira/browse/PIG-1775
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Yan Zhou
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: PIG-1775-2.patch, PIG-1775-3.patch, PIG-1775-4.patch, PIG-1775-4.patch, PIG-1775.patch, piggybank.patch
>
>
> The new logical plan will only be used and the old logical plan will be removed once the new one is stable enough. It is scheduled for the 0.9 release.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PIG-1775) Removal of old logical plan
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xuefu Zhang resolved PIG-1775.
------------------------------
Resolution: Fixed
> Removal of old logical plan
> ---------------------------
>
> Key: PIG-1775
> URL: https://issues.apache.org/jira/browse/PIG-1775
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Yan Zhou
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: PIG-1775-2.patch, PIG-1775-3.patch, PIG-1775-4.patch, PIG-1775-4.patch, PIG-1775-5.patch, PIG-1775.patch, piggybank.patch
>
>
> The new logical plan will only be used and the old logical plan will be removed once the new one is stable enough. It is scheduled for the 0.9 release.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (PIG-1775) Removal of old logical plan
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001761#comment-13001761 ]
Daniel Dai commented on PIG-1775:
---------------------------------
We still have test cases using old logical plan. Xuefu is working on removing them now. I will reassign it to Xuefu.
> Removal of old logical plan
> ---------------------------
>
> Key: PIG-1775
> URL: https://issues.apache.org/jira/browse/PIG-1775
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Yan Zhou
> Assignee: Daniel Dai
> Fix For: 0.9.0
>
>
> The new logical plan will only be used and the old logical plan will be removed once the new one is stable enough. It is scheduled for the 0.9 release.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1775) Removal of old logical plan
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030233#comment-13030233 ]
Daniel Dai commented on PIG-1775:
---------------------------------
Discussed with Woody, we should not mark getSchemaFromString deprecate since our EvalFunc is still using Schema.
> Removal of old logical plan
> ---------------------------
>
> Key: PIG-1775
> URL: https://issues.apache.org/jira/browse/PIG-1775
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Yan Zhou
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: PIG-1775-2.patch, PIG-1775-3.patch, PIG-1775-4.patch, PIG-1775-4.patch, PIG-1775-5.patch, PIG-1775.patch, piggybank.patch
>
>
> The new logical plan will only be used and the old logical plan will be removed once the new one is stable enough. It is scheduled for the 0.9 release.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIG-1775) Removal of old logical plan
Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Dai updated PIG-1775:
----------------------------
Attachment: piggybank.patch
There also a piggybank compilation error. Committed piggybank.patch.
> Removal of old logical plan
> ---------------------------
>
> Key: PIG-1775
> URL: https://issues.apache.org/jira/browse/PIG-1775
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Yan Zhou
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: PIG-1775-2.patch, PIG-1775-3.patch, PIG-1775-4.patch, PIG-1775.patch, piggybank.patch
>
>
> The new logical plan will only be used and the old logical plan will be removed once the new one is stable enough. It is scheduled for the 0.9 release.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1775) Removal of old logical plan
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028308#comment-13028308 ]
Xuefu Zhang commented on PIG-1775:
----------------------------------
Unit test passed. Patch PIG-1775-2.patch is committed to both trunk and 0.9.0.
> Removal of old logical plan
> ---------------------------
>
> Key: PIG-1775
> URL: https://issues.apache.org/jira/browse/PIG-1775
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Yan Zhou
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: PIG-1775-2.patch, PIG-1775.patch
>
>
> The new logical plan will only be used and the old logical plan will be removed once the new one is stable enough. It is scheduled for the 0.9 release.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIG-1775) Removal of old logical plan
Posted by "Xuefu Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027715#comment-13027715 ]
Xuefu Zhang commented on PIG-1775:
----------------------------------
In 0.9.0, there is no way to disable new logical plan, with or without this ticket. If you have problem using 0.9, please log tickets accordingly.
> Removal of old logical plan
> ---------------------------
>
> Key: PIG-1775
> URL: https://issues.apache.org/jira/browse/PIG-1775
> Project: Pig
> Issue Type: Improvement
> Affects Versions: 0.9.0
> Reporter: Yan Zhou
> Assignee: Xuefu Zhang
> Fix For: 0.9.0
>
> Attachments: PIG-1775.patch
>
>
> The new logical plan will only be used and the old logical plan will be removed once the new one is stable enough. It is scheduled for the 0.9 release.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira