[GitHub] [qpid-broker-j] overmeulen commented on a change in pull request #32: QPID-8294: [Brojer-J][JDBC] Configure 'qpid.jdbcstore.inClauseMaxSize' as context variable

[GitBox <gi...@apache.org>]

overmeulen commented on a change in pull request #32: QPID-8294: [Brojer-J][JDBC] Configure 'qpid.jdbcstore.inClauseMaxSize' as context variable
URL: https://github.com/apache/qpid-broker-j/pull/32#discussion_r280101481
 
 

 ##########
 File path: broker-plugins/jdbc-store/src/main/java/org/apache/qpid/server/store/jdbc/AbstractJDBCMessageStore.java
 ##########
 @@ -230,6 +233,8 @@ public Thread newThread(final Runnable r)
         });
         _executor.prestartAllCoreThreads();
 
+        _contextKeys = parent.getContextKeys(false);
+        _inClauseMaxSize = getContextValue(Integer.class, IN_CLAUSE_MAX_SIZE, IN_CLAUSE_MAX_SIZE_DEFAULT);
 
 Review comment:
   You're implicitly setting an order between these 2 lines since getContextValue uses _contextKeys. Maybe _contextKeys should be a parameter of getContextValue?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org