Re: [PR] ARTEMIS-6068 Broker plugins do not receive updated properties on broker.xml reload [artemis]

["jbertram (via GitHub)" <gi...@apache.org>]

jbertram commented on PR #6455:
URL: https://github.com/apache/artemis/pull/6455#issuecomment-4802500562

   I'm concerned that there's a fundamental disconnect between the current methods used to manage broker plugins and the new methods you've added. Consider the following for a user managing an embedded broker:
   
   1. They might call `Configuration#setBrokerPluginConfigurations` and then expect those plugins to be deployed when they start their broker when, in fact, they won't.
   2. They might call `Configuration#registerBrokerPlugin` and then expect to get this plugin's configuration when they invoke `Configuration#getBrokerPluginConfigurations` later, but they won't.
   
   Additionally, these new methods store & manage broker plugin configuration data in different data structures from the existing methods so it's likely that things will get out of sync. 
   
   Ultimately, I think this functionality must be implemented within the confines of the existing API. If this is not possible then we'll have to break the API in order to support this functionality which can only happen in a major release (e.g., 3.0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org