You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/08 19:47:59 UTC
[GitHub] [beam] benWize opened a new pull request, #23109: GA migration - Base actions to use for precommit and postcommit workflows
benWize opened a new pull request, #23109:
URL: https://github.com/apache/beam/pull/23109
As part of the migration of Precommit and Postcommit Jobs from Jenkins to GA in self-hosted runners, this PR contains:
- An [action](https://github.com/benWize/beam/blob/9b648d5b2265286387d9a0c629799feb3cd35a2f/.github/actions/setup-self-hosted-action/action.yml) to set up the SDKs versions in self-hosted runners.
- An [action](https://github.com/benWize/beam/blob/9b648d5b2265286387d9a0c629799feb3cd35a2f/.github/actions/gradle-command-self-hosted-action/action.yml) to run a Gradle command with default arguments, copied from CommonJobProperties from Jenkins files
- An [action](https://github.com/benWize/beam/blob/9b648d5b2265286387d9a0c629799feb3cd35a2f/.github/actions/setup-default-test-properties/action.yml) to setup default test properties (like SDKs versions) from a config file
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23109: GA migration - Base actions to use for precommit and postcommit workflows
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23109:
URL: https://github.com/apache/beam/pull/23109#issuecomment-1245676364
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @Abacn for label build.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #23109: GA migration - Base actions to use for precommit and postcommit workflows
Posted by GitBox <gi...@apache.org>.
damccorm merged PR #23109:
URL: https://github.com/apache/beam/pull/23109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on a diff in pull request #23109: GA migration - Base actions to use for precommit and postcommit workflows
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on code in PR #23109:
URL: https://github.com/apache/beam/pull/23109#discussion_r969897042
##########
.github/actions/setup-self-hosted-action/action.yml:
##########
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: 'Setup environment for self-hosted runners'
+description: 'Setup action to run jobs in a self-hosted runner'
+
+runs:
+ using: "composite"
+ steps:
+ - name: Install python 3.7
+ uses: actions/setup-python@v4
+ with:
+ python-version: "3.7"
+ - name: Install python 3.8
+ uses: actions/setup-python@v4
+ with:
+ python-version: "3.8"
+ - name: Install python 3.9
+ uses: actions/setup-python@v4
+ with:
+ python-version: "3.9"
+ - name: Set Java Version
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'temurin'
+ java-version: 8
+ - name: Set Go Version
+ uses: actions/setup-go@v3
+ with:
+ go-version: '>=1.16.0'
Review Comment:
Thanks for the feedback Danny!
As for the Go version, since this will only be used for precommit and postcommit tasks, would it be ok to only install >=1.18?
The way we thought about this was to install the bare minimum and let each workflow install its appropriate dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on pull request #23109: GA migration - Base actions to use for precommit and postcommit workflows
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on PR #23109:
URL: https://github.com/apache/beam/pull/23109#issuecomment-1245687365
Hi @damccorm,
is this something you can help us to review?
Basically these base actions will support the workflows and needs to be merged before the rest of the workflows.
The changes introduced don't affect current Beam functionality so reviewing/merging shouldn't be much hassle.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #23109: GA migration - Base actions to use for precommit and postcommit workflows
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #23109:
URL: https://github.com/apache/beam/pull/23109#discussion_r969880305
##########
.github/actions/setup-self-hosted-action/action.yml:
##########
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: 'Setup environment for self-hosted runners'
+description: 'Setup action to run jobs in a self-hosted runner'
+
+runs:
Review Comment:
It would be nice to have some optional inputs like:
```
inputs:
requires-py-37:
required: false
default: 'true'
requires-py-38:
required: false
default: 'true'
requires-py-39:
required: false
default: 'true'
requires-java-8:
required: false
default: 'true'
requires-go-16:
required: false
default: 'true'
```
So that a given job can specify if it doesn't need some set of dependencies. I agree installing all of them by default is a good idea though.
##########
.github/actions/setup-self-hosted-action/action.yml:
##########
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: 'Setup environment for self-hosted runners'
+description: 'Setup action to run jobs in a self-hosted runner'
+
+runs:
+ using: "composite"
+ steps:
+ - name: Install python 3.7
+ uses: actions/setup-python@v4
+ with:
+ python-version: "3.7"
+ - name: Install python 3.8
+ uses: actions/setup-python@v4
+ with:
+ python-version: "3.8"
+ - name: Install python 3.9
+ uses: actions/setup-python@v4
+ with:
+ python-version: "3.9"
+ - name: Set Java Version
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'temurin'
+ java-version: 8
+ - name: Set Go Version
+ uses: actions/setup-go@v3
+ with:
+ go-version: '>=1.16.0'
Review Comment:
This version is probably not right. Go SDK tests require >=1.18, and playground tests require 1.16.
I would recommend installing both separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on a diff in pull request #23109: GA migration - Base actions to use for precommit and postcommit workflows
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on code in PR #23109:
URL: https://github.com/apache/beam/pull/23109#discussion_r969938036
##########
.github/actions/setup-self-hosted-action/action.yml:
##########
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: 'Setup environment for self-hosted runners'
+description: 'Setup action to run jobs in a self-hosted runner'
+
+runs:
+ using: "composite"
+ steps:
+ - name: Install python 3.7
+ uses: actions/setup-python@v4
+ with:
+ python-version: "3.7"
+ - name: Install python 3.8
+ uses: actions/setup-python@v4
+ with:
+ python-version: "3.8"
+ - name: Install python 3.9
+ uses: actions/setup-python@v4
+ with:
+ python-version: "3.9"
+ - name: Set Java Version
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'temurin'
+ java-version: 8
+ - name: Set Go Version
+ uses: actions/setup-go@v3
+ with:
+ go-version: '>=1.16.0'
Review Comment:
sounds like a plan! Thanks Danny!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on a diff in pull request #23109: GA migration - Base actions to use for precommit and postcommit workflows
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on code in PR #23109:
URL: https://github.com/apache/beam/pull/23109#discussion_r971101981
##########
.github/actions/setup-self-hosted-action/action.yml:
##########
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: 'Setup environment for self-hosted runners'
+description: 'Setup action to run jobs in a self-hosted runner'
+
+runs:
Review Comment:
Hi Danny!
We can definitely add those inputs to this action so that further workflows can make use of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #23109: GA migration - Base actions to use for precommit and postcommit workflows
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #23109:
URL: https://github.com/apache/beam/pull/23109#discussion_r969932636
##########
.github/actions/setup-self-hosted-action/action.yml:
##########
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: 'Setup environment for self-hosted runners'
+description: 'Setup action to run jobs in a self-hosted runner'
+
+runs:
+ using: "composite"
+ steps:
+ - name: Install python 3.7
+ uses: actions/setup-python@v4
+ with:
+ python-version: "3.7"
+ - name: Install python 3.8
+ uses: actions/setup-python@v4
+ with:
+ python-version: "3.8"
+ - name: Install python 3.9
+ uses: actions/setup-python@v4
+ with:
+ python-version: "3.9"
+ - name: Set Java Version
+ uses: actions/setup-java@v3
+ with:
+ distribution: 'temurin'
+ java-version: 8
+ - name: Set Go Version
+ uses: actions/setup-go@v3
+ with:
+ go-version: '>=1.16.0'
Review Comment:
That should be fine, I would pin it to 1.18 though (not >=1.18) since right now the Go SDK guarantees compat back to 1.18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org