You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2019/12/03 20:12:47 UTC
[GitHub] [trafficcontrol] rawlinp commented on a change in pull request
#4152: Remove some duplicate routes,
tighten up some route regexes in routes.go
rawlinp commented on a change in pull request #4152: Remove some duplicate routes, tighten up some route regexes in routes.go
URL: https://github.com/apache/trafficcontrol/pull/4152#discussion_r353398734
##########
File path: traffic_ops/traffic_ops_golang/routing/routing_test.go
##########
@@ -174,11 +174,18 @@ func TestCompileRoutes(t *testing.T) {
func TestRoutes(t *testing.T) {
fake := ServerData{Config: config.NewFakeConfig()}
- _, _, _, err := Routes(fake)
+ routes, _, _, err := Routes(fake)
if err != nil {
t.Fatalf("expected: no error getting Routes, actual: %v", err)
}
// TODO: verify that all returned Routes are unique
Review comment:
yes, I do :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services