[GitHub] [iceberg] rdblue commented on a diff in pull request #5392: Spark: Fix a separate table cache being created for each rewriteFiles

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5392:
URL: https://github.com/apache/iceberg/pull/5392#discussion_r1014229760


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/RewriteDataFilesSparkAction.java:
##########
@@ -94,10 +95,14 @@
   private boolean useStartingSequenceNumber;
   private RewriteJobOrder rewriteJobOrder;
   private RewriteStrategy strategy = null;
+  private final SparkSession cloneSession;
 
   RewriteDataFilesSparkAction(SparkSession spark, Table table) {
     super(spark);

Review Comment:
   I agree. In general, I think this should probably be overriding `spark()` so that the same context is used everywhere consistently.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org