You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/03 08:42:12 UTC
[GitHub] [rocketmq-client-go] lampnick opened a new pull request, #811: Pull from support tag
lampnick opened a new pull request, #811:
URL: https://github.com/apache/rocketmq-client-go/pull/811
## What is the purpose of the change
fix:https://github.com/apache/rocketmq-client-go/issues/754
feat:pull consumer support namespace and tag
## Brief changelog
fix:https://github.com/apache/rocketmq-client-go/issues/754
feat:pull consumer support namespace and tag
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] codecov-commenter commented on pull request #811: Pull from support tag
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #811:
URL: https://github.com/apache/rocketmq-client-go/pull/811#issuecomment-1196187864
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/811?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#811](https://codecov.io/gh/apache/rocketmq-client-go/pull/811?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (15d8c82) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/129701aef56b3bf215b230ed9285ccb17dc18fe9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (129701a) will **decrease** coverage by `0.12%`.
> The diff coverage is `1.85%`.
> :exclamation: Current head 15d8c82 differs from pull request most recent head 298ad3e. Consider uploading reports for the commit 298ad3e to get more accurate results
```diff
@@ Coverage Diff @@
## master #811 +/- ##
==========================================
- Coverage 25.00% 24.87% -0.13%
==========================================
Files 51 52 +1
Lines 6632 6670 +38
==========================================
+ Hits 1658 1659 +1
- Misses 4750 4787 +37
Partials 224 224
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/811?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [consumer/option.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/811/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uc3VtZXIvb3B0aW9uLmdv) | `23.40% <0.00%> (-0.26%)` | :arrow_down: |
| [consumer/pull\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/811/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uc3VtZXIvcHVsbF9jb25zdW1lci5nbw==) | `0.00% <0.00%> (ø)` | |
| [consumer/strategy.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/811/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uc3VtZXIvc3RyYXRlZ3kuZ28=) | `75.36% <ø> (ø)` | |
| [internal/utils/namespace.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/811/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvdXRpbHMvbmFtZXNwYWNlLmdv) | `0.00% <0.00%> (ø)` | |
| [internal/utils/string.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/811/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW50ZXJuYWwvdXRpbHMvc3RyaW5nLmdv) | `0.00% <0.00%> (ø)` | |
| [primitive/result.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/811/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJpbWl0aXZlL3Jlc3VsdC5nbw==) | `0.00% <0.00%> (ø)` | |
| [consumer/consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/811/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uc3VtZXIvY29uc3VtZXIuZ28=) | `16.41% <10.00%> (-0.06%)` | :arrow_down: |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] lampnick closed pull request #811: Pull from support tag
Posted by GitBox <gi...@apache.org>.
lampnick closed pull request #811: Pull from support tag
URL: https://github.com/apache/rocketmq-client-go/pull/811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] ShannonDing commented on pull request #811: Pull from support tag
Posted by GitBox <gi...@apache.org>.
ShannonDing commented on PR #811:
URL: https://github.com/apache/rocketmq-client-go/pull/811#issuecomment-1191620992
link #768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] lampnick commented on pull request #811: Pull from support tag
Posted by GitBox <gi...@apache.org>.
lampnick commented on PR #811:
URL: https://github.com/apache/rocketmq-client-go/pull/811#issuecomment-1198838206
When I finished the pull consumer then i'll reopen this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] lampnick closed pull request #811: Pull from support tag
Posted by GitBox <gi...@apache.org>.
lampnick closed pull request #811: Pull from support tag
URL: https://github.com/apache/rocketmq-client-go/pull/811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] lampnick commented on pull request #811: Pull from support tag
Posted by GitBox <gi...@apache.org>.
lampnick commented on PR #811:
URL: https://github.com/apache/rocketmq-client-go/pull/811#issuecomment-1196219507
todo:
1、balance queue.
2、consume message failed support retry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org