You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by ar...@apache.org on 2016/06/07 13:37:26 UTC
svn commit: r1747232 - in /ofbiz/branches/release15.12: ./
applications/accounting/script/org/ofbiz/accounting/ledger/
applications/accounting/src/org/ofbiz/accounting/invoice/
applications/accounting/widget/ applications/accounting/widget/ap/forms/
ap...
Author: arunpatidar
Date: Tue Jun 7 13:37:26 2016
New Revision: 1747232
URL: http://svn.apache.org/viewvc?rev=1747232&view=rev
Log:
Applied fix from trunk for revision: 1747223
===
Applying patch from jira ticket OFBIZ-7201.
===============================================================================
Fixed different forms, screens and services affected due to removal of parentTypeId from 'PURCHASE_INVOICE' and 'SALES_INVOICE' InvoiceType data.
==============================================================================
Thanks Anurag Chandak for your contribution.
Modified:
ofbiz/branches/release15.12/ (props changed)
ofbiz/branches/release15.12/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
ofbiz/branches/release15.12/applications/accounting/src/org/ofbiz/accounting/invoice/InvoiceServices.java
ofbiz/branches/release15.12/applications/accounting/widget/InvoiceForms.xml
ofbiz/branches/release15.12/applications/accounting/widget/ap/forms/InvoiceForms.xml
ofbiz/branches/release15.12/applications/accounting/widget/ap/forms/LookupForms.xml
ofbiz/branches/release15.12/applications/accounting/widget/ar/forms/InvoiceForms.xml
ofbiz/branches/release15.12/applications/accounting/widget/ar/forms/LookupForms.xml
ofbiz/branches/release15.12/applications/party/webapp/partymgr/WEB-INF/actions/party/PartyFinancialHistory.groovy (contents, props changed)
Propchange: ofbiz/branches/release15.12/
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Jun 7 13:37:26 2016
@@ -9,4 +9,4 @@
/ofbiz/branches/json-integration-refactoring:1634077-1635900
/ofbiz/branches/multitenant20100310:921280-927264
/ofbiz/branches/release13.07:1547657
-/ofbiz/trunk:1722712,1723007,1723248,1724402,1724411,1724566,1724689,1724763,1724916,1724918,1724925,1724930,1724940,1724943,1724946,1724951,1724957,1724975,1724978,1725006,1725217,1725257,1725561,1725574,1726388,1726486,1726493,1726828,1727894,1728398,1728411,1729005,1729078,1729609,1729809,1730035,1730456,1730735-1730736,1730747,1730758,1730882,1730889,1731382,1731396,1732454,1732570,1732721,1733951,1733956,1734246,1734269,1734276,1734912,1734918,1735021,1735244,1735385,1735398,1735569,1735731,1735734,1735750,1735753,1735756,1735759,1735773,1736083,1736087,1736272,1736434,1736628,1736851,1736854,1736890,1737156,1737440,1738235,1738303,1738407,1738902,1739438,1739448,1739571,1740008,1740442,1740629,1741146,1741563,1741684,1741925,1741930,1741960,1742018,1742097,1742103,1742712,1742737,1742741,1743025,1743027,1743230,1743411-1743412,1743656,1743937,1744117,1744198,1744396,1744662,1744768,1744773,1744911,1745111,1745264,1745428,1745438,1745573,1745577,1745592,1745751,1746228,1746422,
1746459,1746524,1746527,1746536,1746601,1746676,1746714,1746755,1746805,1746832,1746890
+/ofbiz/trunk:1722712,1723007,1723248,1724402,1724411,1724566,1724689,1724763,1724916,1724918,1724925,1724930,1724940,1724943,1724946,1724951,1724957,1724975,1724978,1725006,1725217,1725257,1725561,1725574,1726388,1726486,1726493,1726828,1727894,1728398,1728411,1729005,1729078,1729609,1729809,1730035,1730456,1730735-1730736,1730747,1730758,1730882,1730889,1731382,1731396,1732454,1732570,1732721,1733951,1733956,1734246,1734269,1734276,1734912,1734918,1735021,1735244,1735385,1735398,1735569,1735731,1735734,1735750,1735753,1735756,1735759,1735773,1736083,1736087,1736272,1736434,1736628,1736851,1736854,1736890,1737156,1737440,1738235,1738303,1738407,1738902,1739438,1739448,1739571,1740008,1740442,1740629,1741146,1741563,1741684,1741925,1741930,1741960,1742018,1742097,1742103,1742712,1742737,1742741,1743025,1743027,1743230,1743411-1743412,1743656,1743937,1744117,1744198,1744396,1744662,1744768,1744773,1744911,1745111,1745264,1745428,1745438,1745573,1745577,1745592,1745751,1746228,1746422,
1746459,1746524,1746527,1746536,1746601,1746676,1746714,1746755,1746805,1746832,1746890,1747223
Modified: ofbiz/branches/release15.12/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml
URL: http://svn.apache.org/viewvc/ofbiz/branches/release15.12/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml?rev=1747232&r1=1747231&r2=1747232&view=diff
==============================================================================
--- ofbiz/branches/release15.12/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml (original)
+++ ofbiz/branches/release15.12/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml Tue Jun 7 13:37:26 2016
@@ -2023,8 +2023,8 @@ under the License.
<set field="totalAmountFromInvoice" type="BigDecimal" value="0"/>
<entity-one entity-name="Invoice" value-field="invoice"/>
- <get-related-one value-field="invoice" relation-name="InvoiceType" to-value-field="invoiceType"/>
- <if-compare field="invoiceType.parentTypeId" operator="equals" value="PURCHASE_INVOICE">
+ <set field="isPurchaseInvoice" value="${groovy: org.ofbiz.entity.util.EntityTypeUtil.hasParentType(delegator, 'InvoiceType', 'invoiceTypeId', invoice.getString('invoiceTypeId'), 'parentTypeId', 'PURCHASE_INVOICE')}" type="Boolean"/>
+ <if-compare field="isPurchaseInvoice" operator="equals" value="true" type="Boolean">
<entity-condition entity-name="InvoiceItem" list="invoiceItems" use-cache="true">
<condition-list>
<condition-expr field-name="invoiceItemTypeId" operator="not-equals" value="PINV_SALES_TAX"/>
Modified: ofbiz/branches/release15.12/applications/accounting/src/org/ofbiz/accounting/invoice/InvoiceServices.java
URL: http://svn.apache.org/viewvc/ofbiz/branches/release15.12/applications/accounting/src/org/ofbiz/accounting/invoice/InvoiceServices.java?rev=1747232&r1=1747231&r2=1747232&view=diff
==============================================================================
--- ofbiz/branches/release15.12/applications/accounting/src/org/ofbiz/accounting/invoice/InvoiceServices.java (original)
+++ ofbiz/branches/release15.12/applications/accounting/src/org/ofbiz/accounting/invoice/InvoiceServices.java Tue Jun 7 13:37:26 2016
@@ -55,6 +55,7 @@ import org.ofbiz.entity.condition.Entity
import org.ofbiz.entity.condition.EntityExpr;
import org.ofbiz.entity.condition.EntityOperator;
import org.ofbiz.entity.util.EntityQuery;
+import org.ofbiz.entity.util.EntityTypeUtil;
import org.ofbiz.entity.util.EntityUtil;
import org.ofbiz.entity.util.EntityUtilProperties;
import org.ofbiz.order.order.OrderReadHelper;
@@ -3470,11 +3471,13 @@ public class InvoiceServices {
} else if (EntityQuery.use(delegator).from("InvoiceType").where("invoiceTypeId", invoice.get("invoiceTypeId")).queryOne() == null) {
newErrMsgs.add("Line number " + rec.getRecordNumber() + ": InvoiceItem type id: " + invoice.get("invoiceTypeId") + " not found for invoice: " + currentInvoiceId);
}
- GenericValue invoiceType = EntityQuery.use(delegator).from("InvoiceType").where("invoiceTypeId", invoice.get("invoiceTypeId")).queryOne();
- if ("PURCHASE_INVOICE".equals(invoiceType.getString("parentTypeId")) && !invoice.get("partyId").equals(organizationPartyId)) {
+
+ Boolean isPurchaseInvoice = EntityTypeUtil.hasParentType(delegator, "InvoiceType", "invoiceTypeId", (String) invoice.get("invoiceTypeId"), "parentTypeId", "PURCHASE_INVOICE");
+ Boolean isSalesInvoice = EntityTypeUtil.hasParentType(delegator, "InvoiceType", "invoiceTypeId", (String) invoice.get("invoiceTypeId"), "parentTypeId", "SALES_INVOICE");
+ if (isPurchaseInvoice && !invoice.get("partyId").equals(organizationPartyId)) {
newErrMsgs.add("Line number " + rec.getRecordNumber() + ": A purchase type invoice should have the partyId 'To' being the organizationPartyId(=" + organizationPartyId + ")! however is " + invoice.get("partyId") +"! invoice: " + currentInvoiceId);
}
- if ("SALES_INVOICE".equals(invoiceType.getString("parentTypeId")) && !invoice.get("partyIdFrom").equals(organizationPartyId)) {
+ if (isSalesInvoice && !invoice.get("partyIdFrom").equals(organizationPartyId)) {
newErrMsgs.add("Line number " + rec.getRecordNumber() + ": A sales type invoice should have the partyId 'from' being the organizationPartyId(=" + organizationPartyId + ")! however is " + invoice.get("partyIdFrom") +"! invoice: " + currentInvoiceId);
}
Modified: ofbiz/branches/release15.12/applications/accounting/widget/InvoiceForms.xml
URL: http://svn.apache.org/viewvc/ofbiz/branches/release15.12/applications/accounting/widget/InvoiceForms.xml?rev=1747232&r1=1747231&r2=1747232&view=diff
==============================================================================
--- ofbiz/branches/release15.12/applications/accounting/widget/InvoiceForms.xml (original)
+++ ofbiz/branches/release15.12/applications/accounting/widget/InvoiceForms.xml Tue Jun 7 13:37:26 2016
@@ -236,14 +236,20 @@ under the License.
<form name="NewSalesInvoice" type="single" target="createInvoice" title="Edit Invoice Header" default-map-name="invoice"
header-row-style="header-row" default-table-style="basic-table">
+ <actions>
+ <entity-condition entity-name="InvoiceType" list="invoiceTypeList">
+ <condition-list combine="or">
+ <condition-expr field-name="parentTypeId" value="SALES_INVOICE"/>
+ <condition-expr field-name="invoiceTypeId" value="SALES_INVOICE"/>
+ </condition-list>
+ <order-by field-name="description"/>
+ </entity-condition>
+ </actions>
<field name="statusId"><hidden value="INVOICE_IN_PROCESS"/></field>
<field name="currencyUomId"><hidden value="${defaultOrganizationPartyCurrencyUomId}"/></field>
<field position="2" name="invoiceTypeId">
- <drop-down allow-empty="false" no-current-selected-key="SALES_INVOICE">
- <entity-options entity-name="InvoiceType">
- <entity-constraint name="parentTypeId" value="SALES_INVOICE"/>
- <entity-order-by field-name="description"/>
- </entity-options>
+ <drop-down no-current-selected-key="SALES_INVOICE">
+ <list-options key-name="invoiceTypeId" list-name="invoiceTypeList" description="${description}"/>
</drop-down>
</field>
<field position="1" name="organizationPartyId" parameter-name="partyIdFrom">
@@ -260,14 +266,20 @@ under the License.
</form>
<form name="NewPurchaseInvoice" type="single" target="createInvoice" title="Edit Invoice Header" default-map-name="invoice"
header-row-style="header-row" default-table-style="basic-table">
+ <actions>
+ <entity-condition entity-name="InvoiceType" list="invoiceTypeList">
+ <condition-list combine="or">
+ <condition-expr field-name="parentTypeId" value="PURCHASE_INVOICE"/>
+ <condition-expr field-name="invoiceTypeId" value="PURCHASE_INVOICE"/>
+ </condition-list>
+ <order-by field-name="description"/>
+ </entity-condition>
+ </actions>
<field name="statusId"><hidden value="INVOICE_IN_PROCESS"/></field>
<field name="currencyUomId"><hidden value="${defaultOrganizationPartyCurrencyUomId}"/></field>
<field position="2" name="invoiceTypeId">
- <drop-down allow-empty="false" no-current-selected-key="PURCHASE_INVOICE">
- <entity-options entity-name="InvoiceType">
- <entity-constraint name="parentTypeId" value="PURCHASE_INVOICE"/>
- <entity-order-by field-name="description"/>
- </entity-options>
+ <drop-down no-current-selected-key="PURCHASE_INVOICE">
+ <list-options key-name="invoiceTypeId" list-name="invoiceTypeList" description="${description}"/>
</drop-down>
</field>
<field position="1" name="organizationPartyId" parameter-name="partyId">
@@ -300,10 +312,10 @@ under the License.
<field name="statusId" title="${uiLabelMap.CommonStatus}" use-when="invoice==null"><hidden value="INVOICE_IN_PROCESS"/></field>
<field name="statusId" title="${uiLabelMap.CommonStatus}" position="2" use-when="invoice!=null"><display-entity entity-name="StatusItem"/></field>
<field position="1" name="description"><text size="100"/></field>
- <field position="1" name="partyIdFrom" use-when="invoiceType.getString("parentTypeId").equals("SALES_INVOICE")"><display description="${invoice.partyIdFrom}"/></field>
- <field position="1" name="partyIdFrom" use-when="invoiceType.getString("parentTypeId").equals("PURCHASE_INVOICE")"><lookup target-form-name="LookupPartyName"/></field>
- <field position="2" name="partyIdTo" entry-name="partyId" parameter-name="partyId" use-when="invoiceType.getString("parentTypeId").equals("PURCHASE_INVOICE")"><display description="${invoice.partyId}"/></field>
- <field position="2" name="partyIdTo" entry-name="partyId" parameter-name="partyId" use-when="invoiceType.getString("parentTypeId").equals("SALES_INVOICE")"><lookup target-form-name="LookupPartyName"/></field>
+ <field position="1" name="partyIdFrom" use-when="${groovy:invoiceType.getString("parentTypeId").equals("SALES_INVOICE") || invoiceType.getString("invoiceTypeId").equals("SALES_INVOICE")}"><display description="${invoice.partyIdFrom}"/></field>
+ <field position="1" name="partyIdFrom" use-when="${groovy:invoiceType.getString("parentTypeId").equals("PURCHASE_INVOICE") || invoiceType.getString("invoiceTypeId").equals("PURCHASE_INVOICE")}"><lookup target-form-name="LookupPartyName"/></field>
+ <field position="2" name="partyIdTo" entry-name="partyId" parameter-name="partyId" use-when="${groovy:invoiceType.getString("parentTypeId").equals("PURCHASE_INVOICE") || invoiceType.getString("invoiceTypeId").equals("PURCHASE_INVOICE")}"><display description="${invoice.partyId}"/></field>
+ <field position="2" name="partyIdTo" entry-name="partyId" parameter-name="partyId" use-when="${groovy:invoiceType.getString("parentTypeId").equals("SALES_INVOICE") || invoiceType.getString("invoiceTypeId").equals("SALES_INVOICE")}"><lookup target-form-name="LookupPartyName"/></field>
<field position="1" name="roleTypeId" use-when="invoice!=null&&invoice.getString("invoiceTypeId").equals("SALES_INVOICE")">
<drop-down allow-empty="true">
<entity-options entity-name="RoleType">
Modified: ofbiz/branches/release15.12/applications/accounting/widget/ap/forms/InvoiceForms.xml
URL: http://svn.apache.org/viewvc/ofbiz/branches/release15.12/applications/accounting/widget/ap/forms/InvoiceForms.xml?rev=1747232&r1=1747231&r2=1747232&view=diff
==============================================================================
--- ofbiz/branches/release15.12/applications/accounting/widget/ap/forms/InvoiceForms.xml (original)
+++ ofbiz/branches/release15.12/applications/accounting/widget/ap/forms/InvoiceForms.xml Tue Jun 7 13:37:26 2016
@@ -66,12 +66,17 @@ under the License.
</form>
<form name="FindApInvoices" type="single" target="FindApInvoices" extends="FindInvoices" extends-resource="component://accounting/widget/InvoiceForms.xml">
- <field name="parentTypeId"><hidden value="PURCHASE_INVOICE"/></field>
+ <actions>
+ <entity-condition entity-name="InvoiceType" list="invoiceTypeList">
+ <condition-list combine="or">
+ <condition-expr field-name="parentTypeId" value="PURCHASE_INVOICE"/>
+ <condition-expr field-name="invoiceTypeId" value="PURCHASE_INVOICE"/>
+ </condition-list>
+ </entity-condition>
+ </actions>
<field position="1" name="invoiceTypeId">
- <drop-down allow-empty="true">
- <entity-options entity-name="InvoiceType">
- <entity-constraint name="parentTypeId" value="PURCHASE_INVOICE"/>
- </entity-options>
+ <drop-down>
+ <list-options key-name="invoiceTypeId" list-name="invoiceTypeList" description="${description}"/>
</drop-down>
</field>
</form>
@@ -79,6 +84,12 @@ under the License.
<form name="FindPurchaseInvoices" type="single" target="FindPurchaseInvoices">
<actions>
<set field="organizationPartyId" from-field="parameters.organizationPartyId" default-value="${defaultOrganizationPartyId}"/>
+ <entity-condition entity-name="InvoiceType" list="invoiceTypeList">
+ <condition-list combine="or">
+ <condition-expr field-name="parentTypeId" value="PURCHASE_INVOICE"/>
+ <condition-expr field-name="invoiceTypeId" value="PURCHASE_INVOICE"/>
+ </condition-list>
+ </entity-condition>
</actions>
<field name="partyIdFrom" title="${uiLabelMap.AccountingVendorParty}" position="1"><lookup target-form-name="LookupPartyName"/></field>
<field name="statusId" title="${uiLabelMap.CommonStatus}" position="2">
@@ -94,10 +105,8 @@ under the License.
<field name="fromDueDate" position="1"><date-time/></field>
<field name="thruDueDate" position="2"><date-time/></field>
<field name="invoiceTypeId" position="1">
- <drop-down allow-empty="false">
- <entity-options entity-name="InvoiceType">
- <entity-constraint name="parentTypeId" value="PURCHASE_INVOICE"/>
- </entity-options>
+ <drop-down>
+ <list-options key-name="invoiceTypeId" list-name="invoiceTypeList" description="${description}"/>
</drop-down>
</field>
<field name="search" title="${uiLabelMap.CommonFind}" widget-style="smallSubmit"><submit button-type="button"/></field>
Modified: ofbiz/branches/release15.12/applications/accounting/widget/ap/forms/LookupForms.xml
URL: http://svn.apache.org/viewvc/ofbiz/branches/release15.12/applications/accounting/widget/ap/forms/LookupForms.xml?rev=1747232&r1=1747231&r2=1747232&view=diff
==============================================================================
--- ofbiz/branches/release15.12/applications/accounting/widget/ap/forms/LookupForms.xml (original)
+++ ofbiz/branches/release15.12/applications/accounting/widget/ap/forms/LookupForms.xml Tue Jun 7 13:37:26 2016
@@ -23,12 +23,18 @@ under the License.
<form name="LookupInvoice" target="LookupInvoice" title="" type="single"
header-row-style="header-row" default-table-style="basic-table">
+ <actions>
+ <entity-condition entity-name="InvoiceType" list="invoiceTypeList">
+ <condition-list combine="or">
+ <condition-expr field-name="parentTypeId" value="PURCHASE_INVOICE"/>
+ <condition-expr field-name="invoiceTypeId" value="PURCHASE_INVOICE"/>
+ </condition-list>
+ </entity-condition>
+ </actions>
<field position="1" name="invoiceId"><text-find/></field>
<field position="1" name="invoiceTypeId">
- <drop-down allow-empty="true" no-current-selected-key="PURCHASE_INVOICE">
- <entity-options entity-name="InvoiceType" key-field-name="invoiceTypeId">
- <entity-constraint name="parentTypeId" operator="equals" value="PURCHASE_INVOICE"/>
- </entity-options>
+ <drop-down no-current-selected-key="PURCHASE_INVOICE">
+ <list-options key-name="invoiceTypeId" list-name="invoiceTypeList" description="${description}"/>
</drop-down>
</field>
<field name="statusId" title="${uiLabelMap.CommonStatus}" position="2">
Modified: ofbiz/branches/release15.12/applications/accounting/widget/ar/forms/InvoiceForms.xml
URL: http://svn.apache.org/viewvc/ofbiz/branches/release15.12/applications/accounting/widget/ar/forms/InvoiceForms.xml?rev=1747232&r1=1747231&r2=1747232&view=diff
==============================================================================
--- ofbiz/branches/release15.12/applications/accounting/widget/ar/forms/InvoiceForms.xml (original)
+++ ofbiz/branches/release15.12/applications/accounting/widget/ar/forms/InvoiceForms.xml Tue Jun 7 13:37:26 2016
@@ -67,12 +67,17 @@ under the License.
</form>
<form name="FindArInvoices" type="single" target="FindArInvoices" extends="FindInvoices" extends-resource="component://accounting/widget/InvoiceForms.xml">
- <field name="parentTypeId"><hidden value="SALES_INVOICE"/></field>
+ <actions>
+ <entity-condition entity-name="InvoiceType" list="invoiceTypeList">
+ <condition-list combine="or">
+ <condition-expr field-name="parentTypeId" value="SALES_INVOICE"/>
+ <condition-expr field-name="invoiceTypeId" value="SALES_INVOICE"/>
+ </condition-list>
+ </entity-condition>
+ </actions>
<field name="invoiceTypeId" position="1">
- <drop-down allow-empty="true">
- <entity-options entity-name="InvoiceType">
- <entity-constraint name="parentTypeId" value="SALES_INVOICE"/>
- </entity-options>
+ <drop-down>
+ <list-options key-name="invoiceTypeId" list-name="invoiceTypeList" description="${description}"/>
</drop-down>
</field>
</form>
Modified: ofbiz/branches/release15.12/applications/accounting/widget/ar/forms/LookupForms.xml
URL: http://svn.apache.org/viewvc/ofbiz/branches/release15.12/applications/accounting/widget/ar/forms/LookupForms.xml?rev=1747232&r1=1747231&r2=1747232&view=diff
==============================================================================
--- ofbiz/branches/release15.12/applications/accounting/widget/ar/forms/LookupForms.xml (original)
+++ ofbiz/branches/release15.12/applications/accounting/widget/ar/forms/LookupForms.xml Tue Jun 7 13:37:26 2016
@@ -23,12 +23,18 @@ under the License.
<form name="LookupInvoice" target="LookupInvoice" title="" type="single"
header-row-style="header-row" default-table-style="basic-table">
+ <actions>
+ <entity-condition entity-name="InvoiceType" list="invoiceTypeList">
+ <condition-list combine="or">
+ <condition-expr field-name="parentTypeId" value="SALES_INVOICE"/>
+ <condition-expr field-name="invoiceTypeId" value="SALES_INVOICE"/>
+ </condition-list>
+ </entity-condition>
+ </actions>
<field position="1" name="invoiceId"><text-find/></field>
<field position="1" name="invoiceTypeId">
- <drop-down allow-empty="true" no-current-selected-key="SALES_INVOICE">
- <entity-options entity-name="InvoiceType" key-field-name="invoiceTypeId">
- <entity-constraint name="parentTypeId" operator="equals" value="SALES_INVOICE"/>
- </entity-options>
+ <drop-down no-current-selected-key="SALES_INVOICE">
+ <list-options key-name="invoiceTypeId" list-name="invoiceTypeList" description="${description}"/>
</drop-down>
</field>
<field name="statusId" title="${uiLabelMap.CommonStatus}" position="2">
Modified: ofbiz/branches/release15.12/applications/party/webapp/partymgr/WEB-INF/actions/party/PartyFinancialHistory.groovy
URL: http://svn.apache.org/viewvc/ofbiz/branches/release15.12/applications/party/webapp/partymgr/WEB-INF/actions/party/PartyFinancialHistory.groovy?rev=1747232&r1=1747231&r2=1747232&view=diff
==============================================================================
--- ofbiz/branches/release15.12/applications/party/webapp/partymgr/WEB-INF/actions/party/PartyFinancialHistory.groovy (original)
+++ ofbiz/branches/release15.12/applications/party/webapp/partymgr/WEB-INF/actions/party/PartyFinancialHistory.groovy Tue Jun 7 13:37:26 2016
@@ -60,11 +60,13 @@ invExprs =
invIterator = from("InvoiceAndType").where(invExprs).cursorScrollInsensitive().distinct().queryIterator();
while (invoice = invIterator.next()) {
- if ("PURCHASE_INVOICE".equals(invoice.parentTypeId)) {
+ Boolean isPurchaseInvoice = EntityTypeUtil.hasParentType(delegator, "InvoiceType", "invoiceTypeId", invoice.getString("invoiceTypeId"), "parentTypeId", "PURCHASE_INVOICE");
+ Boolean isSalesInvoice = EntityTypeUtil.hasParentType(delegator, "InvoiceType", "invoiceTypeId", (String) invoice.getString("invoiceTypeId"), "parentTypeId", "SALES_INVOICE");
+ if (isPurchaseInvoice) {
totalInvPuApplied += InvoiceWorker.getInvoiceApplied(invoice, actualCurrency).setScale(2,BigDecimal.ROUND_HALF_UP);
totalInvPuNotApplied += InvoiceWorker.getInvoiceNotApplied(invoice, actualCurrency).setScale(2,BigDecimal.ROUND_HALF_UP);
}
- else if ("SALES_INVOICE".equals(invoice.parentTypeId)) {
+ else if (isSalesInvoice) {
totalInvSaApplied += InvoiceWorker.getInvoiceApplied(invoice, actualCurrency).setScale(2,BigDecimal.ROUND_HALF_UP);
totalInvSaNotApplied += InvoiceWorker.getInvoiceNotApplied(invoice, actualCurrency).setScale(2,BigDecimal.ROUND_HALF_UP);
}
Propchange: ofbiz/branches/release15.12/applications/party/webapp/partymgr/WEB-INF/actions/party/PartyFinancialHistory.groovy
------------------------------------------------------------------------------
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Jun 7 13:37:26 2016
@@ -2,3 +2,4 @@
/ofbiz/branches/dojo1.4/applications/party/webapp/partymgr/WEB-INF/actions/party/PartyFinancialHistory.groovy:951708-952957
/ofbiz/branches/jquery/applications/party/webapp/partymgr/WEB-INF/actions/party/PartyFinancialHistory.groovy:952958-1044489
/ofbiz/branches/multitenant20100310/applications/party/webapp/partymgr/WEB-INF/actions/party/PartyFinancialHistory.groovy:921280-927264
+/ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/actions/party/PartyFinancialHistory.groovy:1747223