You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cassandra.apache.org by GitBox <gi...@apache.org> on 2020/05/15 21:11:01 UTC
[GitHub] [cassandra-diff] yifan-c opened a new pull request #8: Support running diff on multiple keyspaces
yifan-c opened a new pull request #8:
URL: https://github.com/apache/cassandra-diff/pull/8
- Replaced discrete inputs, keyspace and tables, with one list of keyspace table pairs. Now a table is identified by keyspace and table name.
- The scheme of JobMetadataDb is updated correspondingly to replace all 'table_name' with 'keyspace_table_name' and replace `table_names` with `keyspace_table_names`
- DBService in api service is changed to make sure it can query with the new schema.
- Readme is updated to include an example of running with multiple keyspaces.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
For additional commands, e-mail: dev-help@cassandra.apache.org
[GitHub] [cassandra-diff] asfgit closed pull request #8: CASSANDRA-15807 Support running diff on multiple keyspaces
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #8:
URL: https://github.com/apache/cassandra-diff/pull/8
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-diff] yifan-c commented on a change in pull request #8: CASSANDRA-15807 Support running diff on multiple keyspaces
Posted by GitBox <gi...@apache.org>.
yifan-c commented on a change in pull request #8:
URL: https://github.com/apache/cassandra-diff/pull/8#discussion_r426768480
##########
File path: spark-job/src/main/java/org/apache/cassandra/diff/JobMetadataDb.java
##########
@@ -140,10 +142,11 @@ public static void resetStatements()
/**
*
- * @param table
+ * @param keyspaceTablePair
* @return
*/
- public DiffJob.TaskStatus getLastStatus(String table) {
+ // todo
Review comment:
Forgot to remove it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
[GitHub] [cassandra-diff] yifan-c commented on a change in pull request #8: CASSANDRA-15807 Support running diff on multiple keyspaces
Posted by GitBox <gi...@apache.org>.
yifan-c commented on a change in pull request #8:
URL: https://github.com/apache/cassandra-diff/pull/8#discussion_r426767838
##########
File path: spark-job/src/test/java/org/apache/cassandra/diff/DifferTest.java
##########
@@ -74,9 +75,10 @@ public void filterTaskStatusForTables() {
// * t2 is started and has reported some progress, but has not completed
// * t3 has not reported any progress
DiffJob.Split split = new DiffJob.Split(1, 1, BigInteger.ONE, BigInteger.TEN);
- Iterable<String> tables = Lists.newArrayList("t1", "t2", "t3");
- Function<String, DiffJob.TaskStatus> journal = (table) -> {
- switch (table) {
+ //todo
Review comment:
Forgot to remove it. The `todo` was meant to remind me to update the `tables` construction, which was done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [GitHub] [cassandra-diff] yifan-c opened a new pull request #8:
Support running diff on multiple keyspaces
Posted by Yifan Cai <yc...@gmail.com>.
+1
Thank you Mick for the notification fix.
- Yifan
On May 16, 2020, 1:29 AM -0700, Mick Semb Wever <mc...@apache.org>, wrote:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Yifan, fix for notification to go to pr@ instead of dev@ is here:
https://github.com/apache/cassandra-diff/compare/master...thelastpickle:mck/add-asf-yml
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
For additional commands, e-mail: dev-help@cassandra.apache.org
Re: [GitHub] [cassandra-diff] yifan-c opened a new pull request #8:
Support running diff on multiple keyspaces
Posted by Mick Semb Wever <mc...@apache.org>.
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
Yifan, fix for notification to go to pr@ instead of dev@ is here:
https://github.com/apache/cassandra-diff/compare/master...thelastpickle:mck/add-asf-yml
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cassandra.apache.org
For additional commands, e-mail: dev-help@cassandra.apache.org
[GitHub] [cassandra-diff] krummas commented on a change in pull request #8: CASSANDRA-15807 Support running diff on multiple keyspaces
Posted by GitBox <gi...@apache.org>.
krummas commented on a change in pull request #8:
URL: https://github.com/apache/cassandra-diff/pull/8#discussion_r426645453
##########
File path: spark-job/src/test/java/org/apache/cassandra/diff/DifferTest.java
##########
@@ -74,9 +75,10 @@ public void filterTaskStatusForTables() {
// * t2 is started and has reported some progress, but has not completed
// * t3 has not reported any progress
DiffJob.Split split = new DiffJob.Split(1, 1, BigInteger.ONE, BigInteger.TEN);
- Iterable<String> tables = Lists.newArrayList("t1", "t2", "t3");
- Function<String, DiffJob.TaskStatus> journal = (table) -> {
- switch (table) {
+ //todo
Review comment:
anything left here?
##########
File path: spark-job/src/main/java/org/apache/cassandra/diff/JobMetadataDb.java
##########
@@ -140,10 +142,11 @@ public static void resetStatements()
/**
*
- * @param table
+ * @param keyspaceTablePair
* @return
*/
- public DiffJob.TaskStatus getLastStatus(String table) {
+ // todo
Review comment:
anything left here?
##########
File path: spark-job/src/test/java/org/apache/cassandra/diff/DifferTest.java
##########
@@ -22,6 +22,7 @@
import java.math.BigInteger;
import java.util.Map;
import java.util.function.Function;
+import java.util.stream.Collectors;
Review comment:
unused (and there are a few old unused imports below)
##########
File path: api-server/src/main/java/org/apache/cassandra/diff/api/services/DBService.java
##########
@@ -80,8 +80,7 @@ public DBService(JobConfiguration config) {
" job_id," +
" job_start_time," +
" buckets," +
- " keyspace_name, " +
- " table_names, " +
+ " keyspace_table_names, " +
Review comment:
suggestion: we have ["qualified name"](https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/cql3/QualifiedName.java) for keyspace prefixed table names in cassandra, maybe make this `qualified_table_name`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org