[jira] [Commented] (S2GRAPH-41) Refactor PostProcess's toSimpleVertexArrJson.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/S2GRAPH-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153902#comment-15153902 ] 

ASF GitHub Bot commented on S2GRAPH-41:
---------------------------------------

GitHub user SteamShon opened a pull request:

    https://github.com/apache/incubator-s2graph/pull/24

    [S2GRAPH-41] Refactor PostProcess's toSimpleVertexArrJson.

    + seperate logic for buildRawEdges and buildResultJsValue on PostProcess.
    + refactor options on query as queryOption.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-41

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-s2graph/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #24
    
----
commit a2ab77b186eda4921b783c6dab18a8da3714499a
Author: DO YUNG YOON <st...@apache.org>
Date:   2016-02-19T08:31:23Z

    S2GRAPH-41 Refactor PostProcess's toSimpleVertexArrJson.
    
    use seperate logic for buildRawEdges and buildResultJsValue.
    refactor options on query as queryOption.

----


> Refactor PostProcess's toSimpleVertexArrJson.
> ---------------------------------------------
>
>                 Key: S2GRAPH-41
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-41
>             Project: S2Graph
>          Issue Type: Improvement
>            Reporter: DOYUNG YOON
>            Assignee: DOYUNG YOON
>            Priority: Trivial
>              Labels: easyfix, refactor
>
> There is two large logic is coupled in PostProcess.toSimpleVertexArrJson.
> 1. build edges from Seq[QueryRequestWithResult] with their score value.
> 2. group by and order by is processed after 1 is done.
> It would be better to seperate these two logical step into two methods.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)