You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/06/28 06:29:42 UTC
[GitHub] lihaofd closed pull request #11445: [WIP] Fix precision issue of
test case test_rnnrelu_bidirectional and test_rnnrelu_sym
lihaofd closed pull request #11445: [WIP] Fix precision issue of test case test_rnnrelu_bidirectional and test_rnnrelu_sym
URL: https://github.com/apache/incubator-mxnet/pull/11445
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tests/python/unittest/test_operator.py b/tests/python/unittest/test_operator.py
index e07a602b8c1..c23e45b6078 100644
--- a/tests/python/unittest/test_operator.py
+++ b/tests/python/unittest/test_operator.py
@@ -28,7 +28,7 @@
from common import setup_module, with_seed, teardown
import unittest
-def check_rnn_consistency(cell1, cell2, T, N, I, H, grad_req):
+def check_rnn_consistency(cell1, cell2, T, N, I, H, grad_req, rtol, atol):
dshape = (N, T, I)
data = mx.sym.Variable('data')
@@ -51,18 +51,18 @@ def check_rnn_consistency(cell1, cell2, T, N, I, H, grad_req):
# check inference
mod1.forward(batch, is_train=False)
mod2.forward(batch, is_train=False)
- assert_allclose(mod1.get_outputs()[0].asnumpy(), mod2.get_outputs()[0].asnumpy(), rtol=1e-2, atol=1e-4)
+ assert_allclose(mod1.get_outputs()[0].asnumpy(), mod2.get_outputs()[0].asnumpy(), rtol=rtol, atol=atol)
# check training
mod1.forward(batch, is_train=True)
mod2.forward(batch, is_train=True)
- assert_allclose(mod1.get_outputs()[0].asnumpy(), mod2.get_outputs()[0].asnumpy(), rtol=1e-2, atol=1e-4)
+ assert_allclose(mod1.get_outputs()[0].asnumpy(), mod2.get_outputs()[0].asnumpy(), rtol=rtol, atol=atol)
dy = mx.random.uniform(shape=mod1.get_outputs()[0].shape)
mod1.backward(out_grads=[dy])
mod2.backward(out_grads=[dy])
if grad_req != 'null':
- assert_allclose(mod1.get_input_grads()[0].asnumpy(), mod2.get_input_grads()[0].asnumpy(), rtol=1e-2, atol=1e-4)
+ assert_allclose(mod1.get_input_grads()[0].asnumpy(), mod2.get_input_grads()[0].asnumpy(), rtol=rtol, atol=atol)
else:
assert(mod1.get_input_grads()[0] == None)
assert(mod2.get_input_grads()[0] == None)
@@ -78,9 +78,9 @@ def test_lstm_sym():
stack.add(mx.rnn.LSTMCell(H, prefix='l1_'))
stack.add(mx.rnn.LSTMCell(H, prefix='l2_'))
- check_rnn_consistency(fused, stack, T, N, I, H, 'write')
- check_rnn_consistency(fused, stack, T, N, I, H, 'add')
- check_rnn_consistency(fused, stack, T, N, I, H, 'null')
+ check_rnn_consistency(fused, stack, T, N, I, H, 'write', 1e-2, 1e-4)
+ check_rnn_consistency(fused, stack, T, N, I, H, 'add', 1e-2, 1e-4)
+ check_rnn_consistency(fused, stack, T, N, I, H, 'null', 1e-2, 1e-4)
@with_seed()
def test_lstm_bidirectional():
@@ -98,9 +98,9 @@ def test_lstm_bidirectional():
mx.rnn.LSTMCell(H, prefix='r1_'),
output_prefix='bi_lstm_1_'))
- check_rnn_consistency(fused, stack, T, N, I, H, 'write')
- check_rnn_consistency(fused, stack, T, N, I, H, 'add')
- check_rnn_consistency(fused, stack, T, N, I, H, 'null')
+ check_rnn_consistency(fused, stack, T, N, I, H, 'write', 1e-2, 1e-4)
+ check_rnn_consistency(fused, stack, T, N, I, H, 'add', 1e-2, 1e-4)
+ check_rnn_consistency(fused, stack, T, N, I, H, 'null', 1e-2, 1e-4)
@with_seed()
def test_gru_sym():
@@ -111,9 +111,9 @@ def test_gru_sym():
stack.add(mx.rnn.GRUCell(H, prefix='l1_'))
stack.add(mx.rnn.GRUCell(H, prefix='l2_'))
- check_rnn_consistency(fused, stack, T, N, I, H, 'write')
- check_rnn_consistency(fused, stack, T, N, I, H, 'add')
- check_rnn_consistency(fused, stack, T, N, I, H, 'null')
+ check_rnn_consistency(fused, stack, T, N, I, H, 'write', 1e-2, 1e-4)
+ check_rnn_consistency(fused, stack, T, N, I, H, 'add', 1e-2, 1e-4)
+ check_rnn_consistency(fused, stack, T, N, I, H, 'null', 1e-2, 1e-4)
@with_seed()
def test_gru_bidirectional():
@@ -133,9 +133,9 @@ def test_gru_bidirectional():
mx.rnn.GRUCell(H, prefix='r1_'),
output_prefix='bi_gru_1_'))
- check_rnn_consistency(fused, stack, T, N, I, H, 'write')
- check_rnn_consistency(fused, stack, T, N, I, H, 'add')
- check_rnn_consistency(fused, stack, T, N, I, H, 'null')
+ check_rnn_consistency(fused, stack, T, N, I, H, 'write', 1e-2, 1e-4)
+ check_rnn_consistency(fused, stack, T, N, I, H, 'add', 1e-2, 1e-4)
+ check_rnn_consistency(fused, stack, T, N, I, H, 'null', 1e-2, 1e-4)
@with_seed()
def test_rnntanh_sym():
@@ -147,9 +147,9 @@ def test_rnntanh_sym():
stack.add(mx.rnn.RNNCell(H, activation='tanh', prefix='l1_'))
stack.add(mx.rnn.RNNCell(H, activation='tanh', prefix='l2_'))
- check_rnn_consistency(fused, stack, T, N, I, H, 'write')
- check_rnn_consistency(fused, stack, T, N, I, H, 'add')
- check_rnn_consistency(fused, stack, T, N, I, H, 'null')
+ check_rnn_consistency(fused, stack, T, N, I, H, 'write', 1e-2, 1e-4)
+ check_rnn_consistency(fused, stack, T, N, I, H, 'add', 1e-2, 1e-4)
+ check_rnn_consistency(fused, stack, T, N, I, H, 'null', 1e-2, 1e-4)
@with_seed()
def test_rnntanh_bidirectional():
@@ -168,9 +168,9 @@ def test_rnntanh_bidirectional():
mx.rnn.RNNCell(H, activation='tanh', prefix='r1_'),
output_prefix='bi_rnntanh_1_'))
- check_rnn_consistency(fused, stack, T, N, I, H, 'write')
- check_rnn_consistency(fused, stack, T, N, I, H, 'add')
- check_rnn_consistency(fused, stack, T, N, I, H, 'null')
+ check_rnn_consistency(fused, stack, T, N, I, H, 'write', 1e-2, 1e-4)
+ check_rnn_consistency(fused, stack, T, N, I, H, 'add', 1e-2, 1e-4)
+ check_rnn_consistency(fused, stack, T, N, I, H, 'null', 1e-2, 1e-4)
@with_seed()
def test_rnnrelu_sym():
@@ -182,9 +182,9 @@ def test_rnnrelu_sym():
stack.add(mx.rnn.RNNCell(H, activation='relu', prefix='l1_'))
stack.add(mx.rnn.RNNCell(H, activation='relu', prefix='l2_'))
- check_rnn_consistency(fused, stack, T, N, I, H, 'write')
- check_rnn_consistency(fused, stack, T, N, I, H, 'add')
- check_rnn_consistency(fused, stack, T, N, I, H, 'null')
+ check_rnn_consistency(fused, stack, T, N, I, H, 'write', 1e-2, 1e-2)
+ check_rnn_consistency(fused, stack, T, N, I, H, 'add', 1e-2, 1e-2)
+ check_rnn_consistency(fused, stack, T, N, I, H, 'null', 1e-2, 1e-2)
@with_seed()
def test_rnnrelu_bidirectional():
@@ -203,9 +203,9 @@ def test_rnnrelu_bidirectional():
mx.rnn.RNNCell(H, activation='relu', prefix='r1_'),
output_prefix='bi_rnnrelu_1_'))
- check_rnn_consistency(fused, stack, T, N, I, H, 'write')
- check_rnn_consistency(fused, stack, T, N, I, H, 'add')
- check_rnn_consistency(fused, stack, T, N, I, H, 'null')
+ check_rnn_consistency(fused, stack, T, N, I, H, 'write', 1e-2, 1e-2)
+ check_rnn_consistency(fused, stack, T, N, I, H, 'add', 1e-2, 1e-2)
+ check_rnn_consistency(fused, stack, T, N, I, H, 'null', 1e-2, 1e-2)
@with_seed()
def test_lstm_dropout():
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services