[GitHub] [druid] FrankChen021 commented on pull request #12157: Fix node discovery to ignore unknown DruidServices

[GitBox <gi...@apache.org>]

FrankChen021 commented on pull request #12157:
URL: https://github.com/apache/druid/pull/12157#issuecomment-1014184510


   @jihoonson I see. The `JsonTypeInfo` annotation defined on the `DruidService` class tells the jackson to add a `type` property automatically during serialization. And this `type` property conflicts with the `type` field defined in `DataNodeService`.
   
   I don't have a better suggestion considering the backward compatibility. 
   
   I'm wondering if there's any way that we can check or avoid such conflict. 
   How about we can add constraint on the property name of `JsonTypeInfo` annotation, for example it should be `_type`? Such name won't conflict with user defined field name because this naming style is not allowed in users' code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org