You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/11/14 15:18:17 UTC
[GitHub] [incubator-hugegraph-toolchain] javeme commented on a diff in pull request #369: refact(client): adapt import & style with latest code
javeme commented on code in PR #369:
URL: https://github.com/apache/incubator-hugegraph-toolchain/pull/369#discussion_r1021668098
##########
hugegraph-client/src/test/java/org/apache/hugegraph/api/TaskApiTest.java:
##########
@@ -233,13 +233,13 @@ public void testCancel() {
* otherwise they cannot be cancelled
*/
groovy = "for (int i = 0; i < 10; i++) {" +
- "hugegraph.addVertex(T.label, 'man');" +
- "hugegraph.tx().commit();" +
- "try {" +
- "sleep(1000);" +
- "} catch (InterruptedException e) {" +
- "break;" +
- "}" +
+ "hugegraph.addVertex(T.label, 'man');" +
Review Comment:
ditto
##########
hugegraph-client/src/test/java/org/apache/hugegraph/api/ApiTestSuite.java:
##########
@@ -52,51 +52,51 @@
@RunWith(Suite.class)
@Suite.SuiteClasses({
- PropertyKeyApiTest.class,
- VertexLabelApiTest.class,
- EdgeLabelApiTest.class,
- IndexLabelApiTest.class,
- SchemaApiTest.class,
+ PropertyKeyApiTest.class,
Review Comment:
please check
##########
hugegraph-client/src/test/java/org/apache/hugegraph/api/EdgeApiTest.java:
##########
@@ -616,7 +616,6 @@ public void testBatchCreateWithInvalidVertexLabelAndCheck() {
// edgeAPI.get(ids.get(1));
// });
// }
-
Review Comment:
please check
##########
hugegraph-client/src/test/java/org/apache/hugegraph/unit/UnitTestSuite.java:
##########
@@ -24,15 +24,15 @@
@RunWith(Suite.class)
@Suite.SuiteClasses({
- VertexSerializerTest.class,
- PathSerializerTest.class,
- RestResultTest.class,
- BatchElementRequestTest.class,
- PropertyKeyTest.class,
- IndexLabelTest.class,
- CommonUtilTest.class,
- IdUtilTest.class,
- SplicingIdGeneratorTest.class
+ VertexSerializerTest.class,
Review Comment:
ditto
##########
hugegraph-client/src/test/java/org/apache/hugegraph/api/TaskApiTest.java:
##########
@@ -212,8 +212,8 @@ public void testCancel() {
schema().vertexLabel("man").useAutomaticId().ifNotExist().create();
String groovy = "for (int i = 0; i < 10; i++) {" +
- "hugegraph.addVertex(T.label, 'man');" +
- "hugegraph.tx().commit();" +
+ "hugegraph.addVertex(T.label, 'man');" +
Review Comment:
prefer to add some spaces after '"'
##########
hugegraph-client/src/main/java/org/apache/hugegraph/structure/graph/Edge.java:
##########
@@ -71,8 +72,8 @@ public Object sourceId() {
}
if (this.sourceId == null) {
throw new InvalidOperationException(
- "Must set source vertex id or add vertices " +
- "before add edges");
+ "Must set source vertex id or add vertices " +
Review Comment:
please check
##########
hugegraph-client/src/test/java/org/apache/hugegraph/functional/FuncTestSuite.java:
##########
@@ -24,20 +24,20 @@
@RunWith(Suite.class)
@Suite.SuiteClasses({
- PropertyKeyTest.class,
- VertexLabelTest.class,
- EdgeLabelTest.class,
- IndexLabelTest.class,
- SchemaTest.class,
- VertexTest.class,
- EdgeTest.class,
- BatchInsertTest.class,
- GraphManagerTest.class,
- AuthManagerTest.class,
- TraverserManagerTest.class,
- MetricsManagerTest.class,
- HugeClientHttpsTest.class,
- HugeClientTest.class
+ PropertyKeyTest.class,
Review Comment:
ditto
##########
hugegraph-client/src/main/java/org/apache/hugegraph/serializer/direct/reuse/BytesDemo.java:
##########
@@ -124,14 +124,17 @@ private void writeGraphElements() {
vadasB.property("price", "120");
vadasB.id(12345);
- Edge peterCreateLop = new Edge("created").source(peter).target(lop).property("date", "2017-03-24");
+ Edge peterCreateLop = new Edge("created").source(peter).target(lop)
+ .property("date", "2017-03-24");
Review Comment:
align with `.source`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org