You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/02 03:22:50 UTC
[GitHub] [spark] sunchao commented on a change in pull request #34715: [SPARK-37445][BUILD] Rename the maven hadoop profile to hadoop-3 and hadoop-2
sunchao commented on a change in pull request #34715:
URL: https://github.com/apache/spark/pull/34715#discussion_r760734437
##########
File path: python/pyspark/install.py
##########
@@ -65,7 +68,7 @@ def checked_versions(spark_version, hadoop_version, hive_version):
if hadoop_version == "without":
hadoop_version = "without-hadoop"
- elif re.match("^[0-9]+\\.[0-9]+$", hadoop_version):
+ elif re.match("^[0-9]+$", hadoop_version):
Review comment:
Ah saw that. So for `spark_version = 3.2.0` it'll translate `hadoop_version` = `hadoop3` into `hadoop3.2`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org