You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "dlmarion (via GitHub)" <gi...@apache.org> on 2026/03/25 13:21:14 UTC
[PR] Fixed ScanIteratorIT to use different iterator priorities [accumulo]
dlmarion opened a new pull request, #6245:
URL: https://github.com/apache/accumulo/pull/6245
Iterators with the same priority are handled in 2.1.x by then ordering them by their name. In the main branch an exception is thrown when iterators with the same priority are set. This commit removes residual comments from the changes in the 2.1 branch and fixes an IT test to use different priorities when testing iterator order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed ScanIteratorIT to use different iterator priorities [accumulo]
Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion merged PR #6245:
URL: https://github.com/apache/accumulo/pull/6245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed ScanIteratorIT to use different iterator priorities [accumulo]
Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on code in PR #6245:
URL: https://github.com/apache/accumulo/pull/6245#discussion_r2989670188
##########
test/src/main/java/org/apache/accumulo/test/functional/ScanIteratorIT.java:
##########
@@ -303,10 +303,8 @@ public void testIteratorOrder() throws Exception {
assertEquals("base:xa", scanner.iterator().next().getValue().toString());
scanner.addScanIterator(AppendingIterator.configure(70, "m"));
assertEquals("base:xma", scanner.iterator().next().getValue().toString());
- // These have the same priority as a table iterator so the iterators should be ordered by
- // their name in that case
- scanner.addScanIterator(AppendingIterator.configure(50, "b"));
- scanner.addScanIterator(AppendingIterator.configure(100, "c"));
+ scanner.addScanIterator(AppendingIterator.configure(49, "b"));
+ scanner.addScanIterator(AppendingIterator.configure(101, "c"));
Review Comment:
Maybe we want to keep the priorities the same in the test and instead assert that the scan throws an exception. Not sure if we have it, but in 4.0 we do need a test that iters w/ the same priority will fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org