You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2019/12/13 01:31:48 UTC

[GitHub] [incubator-shardingsphere] SteNicholas opened a new pull request #3733: Encrypt select statement in operator

SteNicholas opened a new pull request #3733: Encrypt select statement in operator
URL: https://github.com/apache/incubator-shardingsphere/pull/3733
 
 
   Fixes #3618.
   
   Method `extractInExpressionSegments` of class `PredicateExtractor` extracts expression of parameters. It causes that method `getStopIndex` of class `SQLBuilder` returns the start index of expression, which make method `getConjunctionText` substring logic SQL end index is start index of expression. The return value of `getConjunctionText` includes parenthesis. Therefore, when operator is `IN` of `EncryptPredicateRightValueToken`, it is unnecessary to append `(`.
   
   Changes proposed in this pull request:
   - Remove left parenthesis of `EncryptPredicateRightValueToken` method `toStringForIn()`.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services