You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/13 13:59:15 UTC

[GitHub] [apisix-website] hanzhenfang opened a new pull request #959: chore:Make some icons clearer and add some Media queries

hanzhenfang opened a new pull request #959:
URL: https://github.com/apache/apisix-website/pull/959


   Fixes: #944
   
   Changes: Make some icons clearer and add some Media queries.
   
   hey, I have replaced nine pictures like these.
   The old:
   ![image](https://user-images.githubusercontent.com/99874763/158062785-e4d8cd6c-ae72-4a1c-9827-4693a90b1296.png)![image](https://user-images.githubusercontent.com/99874763/158062765-ee9b0766-ce11-4edf-adf9-efe6897fcc06.png)![image](https://user-images.githubusercontent.com/99874763/158062676-e837cbb9-156d-4052-a5eb-4b946763ed91.png)![image](https://user-images.githubusercontent.com/99874763/158062700-7d8ce155-8375-45d6-ba43-f216f452602d.png)![image](https://user-images.githubusercontent.com/99874763/158062708-5523ad5c-2177-4a18-8d2a-634e21a65658.png)![image](https://user-images.githubusercontent.com/99874763/158062723-c7755460-9a2e-479b-8298-727e768e37db.png)
   
   The new:
   ![image](https://user-images.githubusercontent.com/99874763/158062840-35bd7cc8-fbae-4d12-a30b-a4cf9b2255f3.png)![image](https://user-images.githubusercontent.com/99874763/158062814-ad2647b9-8cd0-4280-bbd4-bba286a2b2e1.png)![image](https://user-images.githubusercontent.com/99874763/158062868-48691ecb-fbc4-467d-8966-34c7b8729c32.png)![image](https://user-images.githubusercontent.com/99874763/158062887-b5b2678a-5a06-4fe3-846d-d380e385bd87.png)![image](https://user-images.githubusercontent.com/99874763/158062879-53f41f78-845c-43a2-bd8f-e1ec6f117383.png)![image](https://user-images.githubusercontent.com/99874763/158062903-3794ce5e-e44e-4b27-80af-3f66c035b4ca.png)
   
   And so on.
   I also add some Media queries to make the page look better on a small screen like this.
   The old:
   
   ![image](https://user-images.githubusercontent.com/99874763/158062939-9dc208a5-efb1-4475-8605-a259414145d6.png)
   
   The new
   ![image](https://user-images.githubusercontent.com/99874763/158062947-0a076502-af31-4809-9a3f-328b8967a3c7.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#issuecomment-1066108166






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#issuecomment-1066108166


   ✔️ Deploy Preview for *apache-apisix* ready!
   
   
   🔨 Explore the source changes: 521ca9a2fe76f78c4daa096326433877b8c6c48b
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/62329ed0cde165000810aec9](https://app.netlify.com/sites/apache-apisix/deploys/62329ed0cde165000810aec9)
   
   😎 Browse the preview: [https://deploy-preview-959--apache-apisix.netlify.app](https://deploy-preview-959--apache-apisix.netlify.app)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#issuecomment-1066108166


   👷 Deploy Preview for *apache-apisix* processing.
   
   
   🔨 Explore the source changes: 00809f3807e9f8abeb36f6650e0db6fe199d40ff
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/623450351e05440008083925](https://app.netlify.com/sites/apache-apisix/deploys/623450351e05440008083925)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] hanzhenfang commented on pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

hanzhenfang commented on pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#issuecomment-1072090212


   @guoqqqi @juzhiyuan 
   I have replaced two WEBP images in JPEG format.
   ![image](https://user-images.githubusercontent.com/99874763/158953396-8e605df0-58a6-4b01-88e8-23d3e80a2a6a.png)
   ![image](https://user-images.githubusercontent.com/99874763/158953416-72ad85ba-18f9-4335-bf6c-b16572e1db60.png)
   But I don't know whether I should take about the compatibility of IE.🤔


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#issuecomment-1066108166


   ✔️ Deploy Preview for *apache-apisix* ready!
   
   
   🔨 Explore the source changes: eea797c14776437878fcd2d3f72e66c8e2341809
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/62342e7b02a14e0008d6f28e](https://app.netlify.com/sites/apache-apisix/deploys/62342e7b02a14e0008d6f28e)
   
   😎 Browse the preview: [https://deploy-preview-959--apache-apisix.netlify.app](https://deploy-preview-959--apache-apisix.netlify.app)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#issuecomment-1066108166


   👷 Deploy Preview for *apache-apisix* processing.
   
   
   🔨 Explore the source changes: eea797c14776437878fcd2d3f72e66c8e2341809
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/62342e7b02a14e0008d6f28e](https://app.netlify.com/sites/apache-apisix/deploys/62342e7b02a14e0008d6f28e)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #959: chore:Make some icons clearer and add some Media queries

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#issuecomment-1066108166


   ✔️ Deploy Preview for *apache-apisix* ready!
   
   
   🔨 Explore the source changes: 73f6abe8772821532b22c5fc9d70f30611a096f3
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/622df8a4e663db0008a77cc8](https://app.netlify.com/sites/apache-apisix/deploys/622df8a4e663db0008a77cc8)
   
   😎 Browse the preview: [https://deploy-preview-959--apache-apisix.netlify.app](https://deploy-preview-959--apache-apisix.netlify.app)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] hanzhenfang commented on a change in pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

hanzhenfang commented on a change in pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#discussion_r828719987



##########
File path: website/src/pages/showcase/index.js
##########
@@ -43,9 +43,9 @@ const Content = (props) => {
   const showcases = siteConfig.customFields.showcases.map((user) => (
     <div className="col col--2 item" key={user.infoLink}>
       <UserCard
-          image={'https://cdn.jsdelivr.net/gh/apache/apisix-website@master/website/static/img/' + user.image}
-          caption={user.caption}
-          infoLink={user.infoLink}
+        image={'../../../static/img/' + user.image}

Review comment:
       @guoqqqi Hello,I have improved my documents.PTAL.😄




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] hanzhenfang commented on a change in pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

hanzhenfang commented on a change in pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#discussion_r829033013



##########
File path: yarn.lock
##########
@@ -0,0 +1,4 @@
+# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
+# yarn lockfile v1
+
+

Review comment:
       > This file does not need to be uploaded, please remove it
   
   Ok




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] guoqqqi commented on a change in pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

guoqqqi commented on a change in pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#discussion_r829787161



##########
File path: website/src/pages/showcase/styles.scss
##########
@@ -35,7 +35,16 @@
 
   @media (max-width: 1200px) {
     .content {
+      display: grid;
+      grid-template-columns: 1fr 1fr 1fr;
       padding: 50px 50px;
     }
   }
+
+@media (max-width: 820px) {
+  .content {
+    display: grid;
+    grid-template-columns: 1fr 1fr;
+  }
+}

Review comment:
       format code




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#issuecomment-1066108166


   ✅ Deploy Preview for *apache-apisix* ready!
   
   
   🔨 Explore the source changes: bb21145074a048d5cd8cf22503e4aa048adba2b0
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/6237d3ffa66a540008f57346](https://app.netlify.com/sites/apache-apisix/deploys/6237d3ffa66a540008f57346)
   
   😎 Browse the preview: [https://deploy-preview-959--apache-apisix.netlify.app](https://deploy-preview-959--apache-apisix.netlify.app)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

juzhiyuan commented on a change in pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#discussion_r830052315



##########
File path: website/static/data/showcases.json
##########
@@ -43,7 +43,7 @@
   },
   {
     "caption": "嘀嗒出行",
-    "image": "showcase/didachuxing.jpg",
+    "image": "showcase/didachuxing.webp",

Review comment:
       Microsoft drops IE, and I support not considering it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

juzhiyuan commented on a change in pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#discussion_r829712920



##########
File path: website/static/data/showcases.json
##########
@@ -43,7 +43,7 @@
   },
   {
     "caption": "嘀嗒出行",
-    "image": "showcase/didachuxing.jpg",
+    "image": "showcase/didachuxing.webp",

Review comment:
       Hi, you could visit https://caniuse.com/?search=webp to check if a property or feature is supported in different browsers.
   
   ![image](https://user-images.githubusercontent.com/2106987/158945642-95cabb4e-2ec7-43a3-8e82-29448208f6e0.png)
   
   
   For webp, it seems that Safari doesn't support it well?
   
   ![image](https://user-images.githubusercontent.com/2106987/158945562-df409750-b19b-4974-ad79-154c70600b97.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] guoqqqi commented on a change in pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

guoqqqi commented on a change in pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#discussion_r829787161



##########
File path: website/src/pages/showcase/styles.scss
##########
@@ -35,7 +35,16 @@
 
   @media (max-width: 1200px) {
     .content {
+      display: grid;
+      grid-template-columns: 1fr 1fr 1fr;
       padding: 50px 50px;
     }
   }
+
+@media (max-width: 820px) {
+  .content {
+    display: grid;
+    grid-template-columns: 1fr 1fr;
+  }
+}

Review comment:
       format code




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#issuecomment-1066108166


   ✔️ Deploy Preview for *apache-apisix* ready!
   
   
   🔨 Explore the source changes: c3b6bf9e97c9aa8744cfe26d270aa654efadec6c
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/6232a73e228dc60008a446ca](https://app.netlify.com/sites/apache-apisix/deploys/6232a73e228dc60008a446ca)
   
   😎 Browse the preview: [https://deploy-preview-959--apache-apisix.netlify.app](https://deploy-preview-959--apache-apisix.netlify.app)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#issuecomment-1066108166


   ✔️ Deploy Preview for *apache-apisix* ready!
   
   
   🔨 Explore the source changes: 00809f3807e9f8abeb36f6650e0db6fe199d40ff
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/623450351e05440008083925](https://app.netlify.com/sites/apache-apisix/deploys/623450351e05440008083925)
   
   😎 Browse the preview: [https://deploy-preview-959--apache-apisix.netlify.app](https://deploy-preview-959--apache-apisix.netlify.app)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#issuecomment-1066108166


   ✔️ Deploy Preview for *apache-apisix* canceled.
   
   
   🔨 Explore the source changes: 4221e3c197b2c6723a9dc870eaf5195826df610e
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/623323449b0cc9000996b6b0](https://app.netlify.com/sites/apache-apisix/deploys/623323449b0cc9000996b6b0)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#issuecomment-1066108166


   👷 Deploy Preview for *apache-apisix* processing.
   
   
   🔨 Explore the source changes: bb21145074a048d5cd8cf22503e4aa048adba2b0
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/6237d3ffa66a540008f57346](https://app.netlify.com/sites/apache-apisix/deploys/6237d3ffa66a540008f57346)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #959: chore:Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#issuecomment-1066108166


   👷 Deploy Preview for *apache-apisix* processing.
   
   
   🔨 Explore the source changes: 521ca9a2fe76f78c4daa096326433877b8c6c48b
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/62329ed0cde165000810aec9](https://app.netlify.com/sites/apache-apisix/deploys/62329ed0cde165000810aec9)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] bzp2010 commented on a change in pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

bzp2010 commented on a change in pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#discussion_r830439370



##########
File path: website/static/data/showcases.json
##########
@@ -43,7 +43,7 @@
   },
   {
     "caption": "嘀嗒出行",
-    "image": "showcase/didachuxing.jpg",
+    "image": "showcase/didachuxing.webp",

Review comment:
       Yes, so I modified it and added the sentence `Hopefully we can make it happen in the future.`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] yzeng25 commented on pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

yzeng25 commented on pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#issuecomment-1070598500


   All checks have passed now ( test and deploy was failed but I re-ran it just now). Pleas take a look @guoqqqi @bzp2010 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] commented on pull request #959: chore:Make some icons clearer and add some Media queries

Posted by GitBox <gi...@apache.org>.

netlify[bot] commented on pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#issuecomment-1066108166


   👷 Deploy Preview for *apache-apisix* processing.
   
   
   🔨 Explore the source changes: 73f6abe8772821532b22c5fc9d70f30611a096f3
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/622df8a4e663db0008a77cc8](https://app.netlify.com/sites/apache-apisix/deploys/622df8a4e663db0008a77cc8)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] guoqqqi commented on a change in pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

guoqqqi commented on a change in pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#discussion_r828909538



##########
File path: yarn.lock
##########
@@ -0,0 +1,4 @@
+# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
+# yarn lockfile v1
+
+

Review comment:
       This file does not need to be uploaded, please remove it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] hanzhenfang commented on a change in pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

hanzhenfang commented on a change in pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#discussion_r829033013



##########
File path: yarn.lock
##########
@@ -0,0 +1,4 @@
+# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
+# yarn lockfile v1
+
+

Review comment:
       > This file does not need to be uploaded, please remove it
   
   Ok

##########
File path: website/static/data/showcases.json
##########
@@ -43,7 +43,7 @@
   },
   {
     "caption": "嘀嗒出行",
-    "image": "showcase/didachuxing.jpg",
+    "image": "showcase/didachuxing.webp",

Review comment:
       @juzhiyuan 
   what about IE?
   ![image](https://user-images.githubusercontent.com/99874763/158946394-c52229af-50c0-4ee7-a3dc-fccf62a643c8.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] yzeng25 commented on pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

yzeng25 commented on pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#issuecomment-1072056417


   LGTM2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#issuecomment-1066108166


   ✅ Deploy Preview for *apache-apisix* ready!
   
   
   🔨 Explore the source changes: 93a7190aa988b9b1ed2f0d03999a854e8feb519f
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/6237c8ba1cbbf00009189e88](https://app.netlify.com/sites/apache-apisix/deploys/6237c8ba1cbbf00009189e88)
   
   😎 Browse the preview: [https://deploy-preview-959--apache-apisix.netlify.app](https://deploy-preview-959--apache-apisix.netlify.app)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] bzp2010 commented on a change in pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

bzp2010 commented on a change in pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#discussion_r830438367



##########
File path: website/static/data/showcases.json
##########
@@ -43,7 +43,7 @@
   },
   {
     "caption": "嘀嗒出行",
-    "image": "showcase/didachuxing.jpg",
+    "image": "showcase/didachuxing.webp",

Review comment:
       Truth be told, I prefer to use svg vector graphics over webp, if icons available.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] hanzhenfang commented on a change in pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

hanzhenfang commented on a change in pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#discussion_r830439896



##########
File path: website/static/data/showcases.json
##########
@@ -43,7 +43,7 @@
   },
   {
     "caption": "嘀嗒出行",
-    "image": "showcase/didachuxing.jpg",
+    "image": "showcase/didachuxing.webp",

Review comment:
       > Yes, so I modified it and added the sentence `Hopefully we can make it happen in the future.`
   
   Yes, I hope so! If I find them， I will pull the request immediately.😄




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

juzhiyuan commented on a change in pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#discussion_r829712920



##########
File path: website/static/data/showcases.json
##########
@@ -43,7 +43,7 @@
   },
   {
     "caption": "嘀嗒出行",
-    "image": "showcase/didachuxing.jpg",
+    "image": "showcase/didachuxing.webp",

Review comment:
       Hi, you could visit https://caniuse.com/?search=webp to check if a property or feature is supported in different browsers.
   
   ![image](https://user-images.githubusercontent.com/2106987/158945642-95cabb4e-2ec7-43a3-8e82-29448208f6e0.png)
   
   
   For webp, it seems that Safari doesn't support it well?
   
   ![image](https://user-images.githubusercontent.com/2106987/158945562-df409750-b19b-4974-ad79-154c70600b97.png)
   

##########
File path: website/static/data/showcases.json
##########
@@ -43,7 +43,7 @@
   },
   {
     "caption": "嘀嗒出行",
-    "image": "showcase/didachuxing.jpg",
+    "image": "showcase/didachuxing.webp",

Review comment:
       Microsoft drops IE, and I support not considering it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#issuecomment-1066108166


   👷 Deploy Preview for *apache-apisix* processing.
   
   
   🔨 Explore the source changes: c3b6bf9e97c9aa8744cfe26d270aa654efadec6c
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/6232a73e228dc60008a446ca](https://app.netlify.com/sites/apache-apisix/deploys/6232a73e228dc60008a446ca)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] hanzhenfang commented on a change in pull request #959: chore:Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

hanzhenfang commented on a change in pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#discussion_r826585480



##########
File path: website/src/pages/showcase/styles.scss
##########
@@ -35,7 +35,16 @@
 
   @media (max-width: 1200px) {
     .content {
+      display: grid;
+      grid-template-columns: 1fr 1fr 1fr;
       padding: 50px 50px;
     }
   }
+
+@media (max-width: 820px) {
+  .content {
+    display: grid;
+    grid-template-columns: 1fr 1fr;
+  }
 }
+}

Review comment:
       > We usually add a blank line at the end of the file
   
   ok I will improve them 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] guoqqqi commented on pull request #959: chore:Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

guoqqqi commented on pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#issuecomment-1067484612


   ![image](https://user-images.githubusercontent.com/72343596/158291320-8d7c15a9-9d8e-424a-8065-f75d87c475ee.png)
   Please note the spacing between the title


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #959: chore:Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#issuecomment-1066108166


   ✔️ Deploy Preview for *apache-apisix* ready!
   
   
   🔨 Explore the source changes: efb6718194caa88b8813c9ed072881d212211902
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/622e004a46be910009a1dd68](https://app.netlify.com/sites/apache-apisix/deploys/622e004a46be910009a1dd68)
   
   😎 Browse the preview: [https://deploy-preview-959--apache-apisix.netlify.app](https://deploy-preview-959--apache-apisix.netlify.app)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #959: chore:Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#issuecomment-1066108166


   👷 Deploy Preview for *apache-apisix* processing.
   
   
   🔨 Explore the source changes: efb6718194caa88b8813c9ed072881d212211902
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/622e004a46be910009a1dd68](https://app.netlify.com/sites/apache-apisix/deploys/622e004a46be910009a1dd68)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] guoqqqi commented on a change in pull request #959: chore:Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

guoqqqi commented on a change in pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#discussion_r826519560



##########
File path: website/static/data/showcases.json
##########
@@ -401,4 +401,4 @@
     "infoLink": "https://www.xinpianchang.com",
     "pinned": true
   }
-]
+]

Review comment:
       ditto

##########
File path: website/src/pages/showcase/styles.scss
##########
@@ -35,7 +35,16 @@
 
   @media (max-width: 1200px) {
     .content {
+      display: grid;
+      grid-template-columns: 1fr 1fr 1fr;
       padding: 50px 50px;
     }
   }
+
+@media (max-width: 820px) {
+  .content {
+    display: grid;
+    grid-template-columns: 1fr 1fr;
+  }
 }
+}

Review comment:
       We usually add a blank line at the end of the file




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] yzeng25 commented on pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

yzeng25 commented on pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#issuecomment-1072056417


   LGTM2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] bzp2010 commented on a change in pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

bzp2010 commented on a change in pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#discussion_r830438367



##########
File path: website/static/data/showcases.json
##########
@@ -43,7 +43,7 @@
   },
   {
     "caption": "嘀嗒出行",
-    "image": "showcase/didachuxing.jpg",
+    "image": "showcase/didachuxing.webp",

Review comment:
       Truth be told, I prefer to use svg vector graphics over webp, if icons available. Hopefully we can make it happen in the future.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#issuecomment-1066108166


   👷 Deploy Preview for *apache-apisix* processing.
   
   
   🔨 Explore the source changes: 93a7190aa988b9b1ed2f0d03999a854e8feb519f
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/6237c8ba1cbbf00009189e88](https://app.netlify.com/sites/apache-apisix/deploys/6237c8ba1cbbf00009189e88)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

juzhiyuan commented on a change in pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#discussion_r830607387



##########
File path: website/static/data/showcases.json
##########
@@ -401,4 +401,4 @@
     "infoLink": "https://www.xinpianchang.com",
     "pinned": true
   }
-]
+]

Review comment:
       ```suggestion
   ]
   
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] juzhiyuan merged pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

juzhiyuan merged pull request #959:
URL: https://github.com/apache/apisix-website/pull/959


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] hanzhenfang commented on pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

hanzhenfang commented on pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#issuecomment-1072090212


   @guoqqqi @juzhiyuan 
   I have replaced two WEBP images in JPEG format.
   ![image](https://user-images.githubusercontent.com/99874763/158953396-8e605df0-58a6-4b01-88e8-23d3e80a2a6a.png)
   ![image](https://user-images.githubusercontent.com/99874763/158953416-72ad85ba-18f9-4335-bf6c-b16572e1db60.png)
   But I don't know whether I should take about the compatibility of IE.🤔


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

netlify[bot] edited a comment on pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#issuecomment-1066108166


   👷 Deploy Preview for *apache-apisix* processing.
   
   
   🔨 Explore the source changes: 4221e3c197b2c6723a9dc870eaf5195826df610e
   
   🔍 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/623323449b0cc9000996b6b0](https://app.netlify.com/sites/apache-apisix/deploys/623323449b0cc9000996b6b0)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] hanzhenfang commented on a change in pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

hanzhenfang commented on a change in pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#discussion_r830439091



##########
File path: website/static/data/showcases.json
##########
@@ -43,7 +43,7 @@
   },
   {
     "caption": "嘀嗒出行",
-    "image": "showcase/didachuxing.jpg",
+    "image": "showcase/didachuxing.webp",

Review comment:
       > Truth be told, I prefer to use SVG vector graphics over webp, if icons available.
   
   I'm sorry about that.I have tried my best to find these icons of SVG, but it's too hard find them.And some of their website ICONS are not particularly clear.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] hanzhenfang commented on a change in pull request #959: chore: Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

hanzhenfang commented on a change in pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#discussion_r829715301



##########
File path: website/static/data/showcases.json
##########
@@ -43,7 +43,7 @@
   },
   {
     "caption": "嘀嗒出行",
-    "image": "showcase/didachuxing.jpg",
+    "image": "showcase/didachuxing.webp",

Review comment:
       @juzhiyuan 
   what about IE?
   ![image](https://user-images.githubusercontent.com/99874763/158946394-c52229af-50c0-4ee7-a3dc-fccf62a643c8.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] guoqqqi commented on a change in pull request #959: chore:Make some icons clearer and add some media queries

Posted by GitBox <gi...@apache.org>.

guoqqqi commented on a change in pull request #959:
URL: https://github.com/apache/apisix-website/pull/959#discussion_r826522461



##########
File path: website/src/pages/showcase/index.js
##########
@@ -43,9 +43,9 @@ const Content = (props) => {
   const showcases = siteConfig.customFields.showcases.map((user) => (
     <div className="col col--2 item" key={user.infoLink}>
       <UserCard
-          image={'https://cdn.jsdelivr.net/gh/apache/apisix-website@master/website/static/img/' + user.image}
-          caption={user.caption}
-          infoLink={user.infoLink}
+        image={'../../../static/img/' + user.image}

Review comment:
       Here you should continue to use the CDN to speed up the link




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org