You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "Jiri Daněk (JIRA)" <ji...@apache.org> on 2019/03/12 15:43:00 UTC
[jira] [Updated] (ARTEMIS-2272) Suspicious call
`queueMap.get(ref.getQueue())` in RefsOperation.java
[ https://issues.apache.org/jira/browse/ARTEMIS-2272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jiri Daněk updated ARTEMIS-2272:
--------------------------------
Description:
{code:java}
protected void rollbackRedelivery(Transaction tx, MessageReference ref, long timeBase, Map<QueueImpl, LinkedList<MessageReference>> queueMap) throws Exception {
// if ignore redelivery check, we just perform redelivery straight
if (ref.getQueue().checkRedelivery(ref, timeBase, ignoreRedeliveryCheck)) {
LinkedList<MessageReference> toCancel = queueMap.get(ref.getQueue());
{code}
-I am thinking that probably {{queueMap.get(ref);}} is the correct call, judging by the types of the objects involved.-
This is from an IntelliJ warning "Suspicious call to 'Map.get' less... (Ctrl+1)
Inspection info: Reports method calls to parameterized collections, where actual argument type does not correspond to the collection's elements type."
was:
{code:java}
protected void rollbackRedelivery(Transaction tx, MessageReference ref, long timeBase, Map<QueueImpl, LinkedList<MessageReference>> queueMap) throws Exception {
// if ignore redelivery check, we just perform redelivery straight
if (ref.getQueue().checkRedelivery(ref, timeBase, ignoreRedeliveryCheck)) {
LinkedList<MessageReference> toCancel = queueMap.get(ref.getQueue());
{code}
I am thinking that probably {{queueMap.get(ref);}} is the correct call, judging by the types of the objects involved.
This is from an IntelliJ warning "Suspicious call to 'Map.get' less... (Ctrl+1)
Inspection info: Reports method calls to parameterized collections, where actual argument type does not correspond to the collection's elements type."
> Suspicious call `queueMap.get(ref.getQueue())` in RefsOperation.java
> --------------------------------------------------------------------
>
> Key: ARTEMIS-2272
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2272
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 1.6.0
> Reporter: Jiri Daněk
> Priority: Major
>
> {code:java}
> protected void rollbackRedelivery(Transaction tx, MessageReference ref, long timeBase, Map<QueueImpl, LinkedList<MessageReference>> queueMap) throws Exception {
> // if ignore redelivery check, we just perform redelivery straight
> if (ref.getQueue().checkRedelivery(ref, timeBase, ignoreRedeliveryCheck)) {
> LinkedList<MessageReference> toCancel = queueMap.get(ref.getQueue());
> {code}
> -I am thinking that probably {{queueMap.get(ref);}} is the correct call, judging by the types of the objects involved.-
> This is from an IntelliJ warning "Suspicious call to 'Map.get' less... (Ctrl+1)
> Inspection info: Reports method calls to parameterized collections, where actual argument type does not correspond to the collection's elements type."
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)