You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "ueshin (via GitHub)" <gi...@apache.org> on 2025/02/26 22:33:15 UTC
[PR] [SPARK-51326][CONNECT] Remove LazyExpression proto message [spark]
ueshin opened a new pull request, #50093:
URL: https://github.com/apache/spark/pull/50093
### What changes were proposed in this pull request?
Removes `LazyExpression` proto message.
Any features using this proto message is not released yet, so it's safe to remove from master and branch-4.0.
### Why are the changes needed?
Discussed offline and found out it's not necessary in Spark Connect.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
The existing tests should pass.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51326][CONNECT] Remove LazyExpression proto message [spark]
Posted by "ueshin (via GitHub)" <gi...@apache.org>.
ueshin commented on PR #50093:
URL: https://github.com/apache/spark/pull/50093#issuecomment-2688892681
I reran the compatibility test after #50094 was merged and it passed.
- https://github.com/ueshin/apache-spark/actions/runs/13554631961/job/37946210197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51326][CONNECT] Remove LazyExpression proto message [spark]
Posted by "ueshin (via GitHub)" <gi...@apache.org>.
ueshin commented on PR #50093:
URL: https://github.com/apache/spark/pull/50093#issuecomment-2686499500
As "Protobuf breaking change detection and Python CodeGen check" failed with:
```
Error: Previously present message "LazyExpression" was deleted from file.
Error: Previously present field "22" with name "subquery_expression" on message "Expression" was deleted.
Error: Field "21" with name "subquery_expression" on message "Expression" changed option "json_name" from "lazyExpression" to "subqueryExpression".
Error: Field "21" with name "subquery_expression" on message "Expression" changed type from "spark.connect.LazyExpression" to "spark.connect.SubqueryExpression".
Error: Field "21" on message "Expression" changed name from "lazy_expression" to "subquery_expression".
Error: buf found 5 breaking changes.
```
#50094 should show it's not broken compared to 3.5.
- https://github.com/ueshin/apache-spark/actions/runs/13555973829/job/37890264016
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51326][CONNECT] Remove LazyExpression proto message [spark]
Posted by "ueshin (via GitHub)" <gi...@apache.org>.
ueshin closed pull request #50093: [SPARK-51326][CONNECT] Remove LazyExpression proto message
URL: https://github.com/apache/spark/pull/50093
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-51326][CONNECT] Remove LazyExpression proto message [spark]
Posted by "ueshin (via GitHub)" <gi...@apache.org>.
ueshin commented on PR #50093:
URL: https://github.com/apache/spark/pull/50093#issuecomment-2688893677
Thanks! merging to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org