You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/02/14 22:36:53 UTC
[GitHub] xtinec commented on a change in pull request #6872: Relayout SQL
Editor
xtinec commented on a change in pull request #6872: Relayout SQL Editor
URL: https://github.com/apache/incubator-superset/pull/6872#discussion_r257041525
##########
File path: superset/assets/src/SqlLab/components/SqlEditor.jsx
##########
@@ -187,9 +202,44 @@ class SqlEditor extends React.PureComponent {
ctasChanged(event) {
this.setState({ ctas: event.target.value });
}
- sqlEditorHeight() {
- const horizontalScrollbarHeight = 25;
- return parseInt(this.props.getHeight(), 10) - horizontalScrollbarHeight;
+ queryPane() {
+ const hotkeys = this.getHotkeyConfig();
+ const { aceEditorHeight, southPaneHeight } = this.getAceEditorAndSouthPaneHeights(
+ this.state.height, INITIAL_NORTH_PERCENT, INITIAL_SOUTH_PERCENT);
+ return (
+ <div className="queryPane">
+ <Split
+ sizes={[INITIAL_NORTH_PERCENT, INITIAL_SOUTH_PERCENT]}
+ minSize={200}
+ direction="vertical"
+ gutterSize={GUTTER_HEIGHT}
+ onDragStart={this.onResizeStart}
+ onDragEnd={this.onResizeEnd}
+ >
+ <div ref="north">
Review comment:
Yep, we can.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org