You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "jonkeane (via GitHub)" <gi...@apache.org> on 2025/01/01 17:33:43 UTC
[PR] [WIP] used C++17 with GCC15 for now [arrow]
jonkeane opened a new pull request, #45150:
URL: https://github.com/apache/arrow/pull/45150
### Rationale for this change
Run GCC15 crossbow job with C++17. I'll make an issue if we end up wanting to use this.
Separately: I've been getting a lot of connection reset on downloading dependencies in cmake when I run this locally. I haven't had a chance to figure out why this is, but it seems to happen to me locally pretty consistently today. ` Recv failure: Connection reset by peer // OpenSSL SSL_read: Connection reset by peer, errno 104 // Failed receiving HTTP2 data: 56(Failure when receiving data from the peer) // Connection #1 to host codeload.github.com left intact` in case anyone has seen this before and has an idea what's up there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] Use C++17 with GCC15 for now [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on code in PR #45150:
URL: https://github.com/apache/arrow/pull/45150#discussion_r1903117176
##########
ci/docker/debian-experimental-cpp.dockerfile:
##########
@@ -111,13 +112,13 @@ RUN /arrow/ci/scripts/install_sccache.sh unknown-linux-musl /usr/local/bin
# Prioritize system packages and local installation.
ENV ARROW_ACERO=ON \
ARROW_AZURE=ON \
- ARROW_BUILD_TESTS=ON \
+ ARROW_BUILD_TESTS=OFF \
ARROW_DATASET=ON \
ARROW_DEPENDENCY_SOURCE=SYSTEM \
ARROW_DATASET=ON \
ARROW_FLIGHT=ON \
ARROW_FLIGHT_SQL=ON \
- ARROW_GANDIVA=ON \
+ ARROW_GANDIVA=OFF \
Review Comment:
Ah yeah, for posterity / anyone else reading:
```
/usr/include/c++/15/ciso646:46:4: error: #warning "<ciso646> is deprecated in C++17, use <version> to detect implementation-specific macros" [-Werror=cpp]
46 | # warning "<ciso646> is deprecated in C++17, use <version> to detect implementation-specific macros"
| ^~~~~~~
cc1plus: all warnings being treated as errors
```
I think this is ok for now. I'm preparing the small thrift patch for CRAN. We don't build tests or Gandiva there so we won't get hit with these. We can deal with them (or ideally they are dealt with upstream...) when GCC 15 is actually released
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] used C++17 with GCC15 for now [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45150:
URL: https://github.com/apache/arrow/pull/45150#issuecomment-2567113802
Revision: b9cd0376eb093683f221536e8ef623d8d236a6e6
Submitted crossbow builds: [ursacomputing/crossbow @ actions-584d6629d4](https://github.com/ursacomputing/crossbow/branches/all?query=actions-584d6629d4)
|Task|Status|
|----|------|
|test-debian-experimental-cpp-gcc-15|[](https://github.com/ursacomputing/crossbow/actions/runs/12573531706/job/35046642539)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] Use C++17 with GCC15 for now [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane closed pull request #45150: [WIP] Use C++17 with GCC15 for now
URL: https://github.com/apache/arrow/pull/45150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] Use C++17 with GCC15 for now [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on code in PR #45150:
URL: https://github.com/apache/arrow/pull/45150#discussion_r1903105919
##########
ci/docker/debian-experimental-cpp.dockerfile:
##########
@@ -111,13 +112,13 @@ RUN /arrow/ci/scripts/install_sccache.sh unknown-linux-musl /usr/local/bin
# Prioritize system packages and local installation.
ENV ARROW_ACERO=ON \
ARROW_AZURE=ON \
- ARROW_BUILD_TESTS=ON \
+ ARROW_BUILD_TESTS=OFF \
ARROW_DATASET=ON \
ARROW_DEPENDENCY_SOURCE=SYSTEM \
ARROW_DATASET=ON \
ARROW_FLIGHT=ON \
ARROW_FLIGHT_SQL=ON \
- ARROW_GANDIVA=ON \
+ ARROW_GANDIVA=OFF \
Review Comment:
I'll try!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] Use C++17 with GCC15 for now [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #45150:
URL: https://github.com/apache/arrow/pull/45150#discussion_r1903116678
##########
ci/docker/debian-experimental-cpp.dockerfile:
##########
@@ -111,13 +112,13 @@ RUN /arrow/ci/scripts/install_sccache.sh unknown-linux-musl /usr/local/bin
# Prioritize system packages and local installation.
ENV ARROW_ACERO=ON \
ARROW_AZURE=ON \
- ARROW_BUILD_TESTS=ON \
+ ARROW_BUILD_TESTS=OFF \
ARROW_DATASET=ON \
ARROW_DEPENDENCY_SOURCE=SYSTEM \
ARROW_DATASET=ON \
ARROW_FLIGHT=ON \
ARROW_FLIGHT_SQL=ON \
- ARROW_GANDIVA=ON \
+ ARROW_GANDIVA=OFF \
Review Comment:
Sorry... This didn't help...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] used C++17 with GCC15 for now [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45150:
URL: https://github.com/apache/arrow/pull/45150#issuecomment-2567150556
Revision: 891b839dab99ebea848dd259b38159823ea84878
Submitted crossbow builds: [ursacomputing/crossbow @ actions-acb43189c9](https://github.com/ursacomputing/crossbow/branches/all?query=actions-acb43189c9)
|Task|Status|
|----|------|
|test-debian-experimental-cpp-gcc-15|[](https://github.com/ursacomputing/crossbow/actions/runs/12574509927/job/35048583433)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] used C++17 with GCC15 for now [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #45150:
URL: https://github.com/apache/arrow/pull/45150#issuecomment-2567098485
@github-actions crossbow submit test-debian-experimental-cpp-gcc-15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] used C++17 with GCC15 for now [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45150:
URL: https://github.com/apache/arrow/pull/45150#issuecomment-2567146064
Revision: 2f9b2d224407bff0d2be57dad5d7740acd4c1fa7
Submitted crossbow builds: [ursacomputing/crossbow @ actions-32f24d7238](https://github.com/ursacomputing/crossbow/branches/all?query=actions-32f24d7238)
|Task|Status|
|----|------|
|test-debian-experimental-cpp-gcc-15|[](https://github.com/ursacomputing/crossbow/actions/runs/12574377042/job/35048329667)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] Use C++17 with GCC15 for now [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #45150:
URL: https://github.com/apache/arrow/pull/45150#discussion_r1900497711
##########
ci/docker/debian-experimental-cpp.dockerfile:
##########
@@ -111,13 +112,13 @@ RUN /arrow/ci/scripts/install_sccache.sh unknown-linux-musl /usr/local/bin
# Prioritize system packages and local installation.
ENV ARROW_ACERO=ON \
ARROW_AZURE=ON \
- ARROW_BUILD_TESTS=ON \
+ ARROW_BUILD_TESTS=OFF \
ARROW_DATASET=ON \
ARROW_DEPENDENCY_SOURCE=SYSTEM \
ARROW_DATASET=ON \
ARROW_FLIGHT=ON \
ARROW_FLIGHT_SQL=ON \
- ARROW_GANDIVA=ON \
+ ARROW_GANDIVA=OFF \
Review Comment:
Can we use newer LLVM instead?
```diff
diff --git a/dev/tasks/tasks.yml b/dev/tasks/tasks.yml
index 9f04d33f83..fb7d5a4ce5 100644
--- a/dev/tasks/tasks.yml
+++ b/dev/tasks/tasks.yml
@@ -1011,6 +1011,7 @@ tasks:
ARCH: "amd64"
DEBIAN: "experimental"
GCC: "15"
+ LLVM: "19"
flags: "-e CMAKE_CXX_STANDARD=20"
image: debian-cpp
```
##########
ci/docker/debian-experimental-cpp.dockerfile:
##########
@@ -73,6 +73,7 @@ RUN if [ -n "${gcc}" ]; then \
libutf8proc-dev \
libxml2-dev \
libxsimd-dev \
+ libxxhash-dev \
Review Comment:
Ah, sid/experimental's `liblz4.so` uses `libxxhash.so`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] used C++17 with GCC15 for now [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45150:
URL: https://github.com/apache/arrow/pull/45150#issuecomment-2567099013
Revision: 7e63bd19d37936024ca2adefa0bf4114c24c199a
Submitted crossbow builds: [ursacomputing/crossbow @ actions-557c07a1a5](https://github.com/ursacomputing/crossbow/branches/all?query=actions-557c07a1a5)
|Task|Status|
|----|------|
|test-debian-experimental-cpp-gcc-15|[](https://github.com/ursacomputing/crossbow/actions/runs/12573155580/job/35045889116)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] Use C++17 with GCC15 for now [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45150:
URL: https://github.com/apache/arrow/pull/45150#issuecomment-2571316599
Revision: 59a5dc096bbdee23c830f5675053f681da991b75
Submitted crossbow builds: [ursacomputing/crossbow @ actions-aa809b4bcc](https://github.com/ursacomputing/crossbow/branches/all?query=actions-aa809b4bcc)
|Task|Status|
|----|------|
|test-debian-experimental-cpp-gcc-15|[](https://github.com/ursacomputing/crossbow/actions/runs/12611161116/job/35146541629)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] used C++17 with GCC15 for now [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45150:
URL: https://github.com/apache/arrow/pull/45150#issuecomment-2567089642
Revision: 31f3ccece1f9a88d4a18b8e2272149bd65592cf3
Submitted crossbow builds: [ursacomputing/crossbow @ actions-3cb10fc026](https://github.com/ursacomputing/crossbow/branches/all?query=actions-3cb10fc026)
|Task|Status|
|----|------|
|test-debian-experimental-cpp-gcc-15|[](https://github.com/ursacomputing/crossbow/actions/runs/12572940081/job/35045436829)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] Use C++17 with GCC15 for now [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #45150:
URL: https://github.com/apache/arrow/pull/45150#issuecomment-2571316079
@github-actions crossbow submit test-debian-experimental-cpp-gcc-15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] Use C++17 with GCC15 for now [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #45150:
URL: https://github.com/apache/arrow/pull/45150#discussion_r1903116711
##########
ci/docker/debian-experimental-cpp.dockerfile:
##########
@@ -111,7 +111,7 @@ RUN /arrow/ci/scripts/install_sccache.sh unknown-linux-musl /usr/local/bin
# Prioritize system packages and local installation.
ENV ARROW_ACERO=ON \
ARROW_AZURE=ON \
- ARROW_BUILD_TESTS=ON \
+ ARROW_BUILD_TESTS=OFF \
Review Comment:
Could you try `BUILD_WARNING_LEVEL=PRODUCTION` instead?
It doesn't add `-Werror`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] used C++17 with GCC15 for now [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on code in PR #45150:
URL: https://github.com/apache/arrow/pull/45150#discussion_r1900462186
##########
ci/docker/debian-experimental-cpp.dockerfile:
##########
@@ -73,6 +73,7 @@ RUN if [ -n "${gcc}" ]; then \
libutf8proc-dev \
libxml2-dev \
libxsimd-dev \
+ libxxhash-dev \
Review Comment:
Without this I had linker errors with `xxhash`. Though I'm surprised this _isn't_ needed for debian 12?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] used C++17 with GCC15 for now [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #45150:
URL: https://github.com/apache/arrow/pull/45150#issuecomment-2567145429
@github-actions crossbow submit test-debian-experimental-cpp-gcc-15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] used C++17 with GCC15 for now [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #45150:
URL: https://github.com/apache/arrow/pull/45150#issuecomment-2567088649
@igthub-actions crossbow submit test-debian-experimental-cpp-gcc-15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] used C++17 with GCC15 for now [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #45150:
URL: https://github.com/apache/arrow/pull/45150#issuecomment-2567088950
@github-actions crossbow submit test-debian-experimental-cpp-gcc-15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] used C++17 with GCC15 for now [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on code in PR #45150:
URL: https://github.com/apache/arrow/pull/45150#discussion_r1900440474
##########
ci/docker/debian-experimental-cpp.dockerfile:
##########
@@ -111,7 +111,7 @@ RUN /arrow/ci/scripts/install_sccache.sh unknown-linux-musl /usr/local/bin
# Prioritize system packages and local installation.
ENV ARROW_ACERO=ON \
ARROW_AZURE=ON \
- ARROW_BUILD_TESTS=ON \
+ ARROW_BUILD_TESTS=OFF \
Review Comment:
I'll revert this, but since we don't build tests on CRAN I'm checking to see if this being off gets us to a successful build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] used C++17 with GCC15 for now [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #45150:
URL: https://github.com/apache/arrow/pull/45150#issuecomment-2567113189
@github-actions crossbow submit test-debian-experimental-cpp-gcc-15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [WIP] used C++17 with GCC15 for now [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #45150:
URL: https://github.com/apache/arrow/pull/45150#issuecomment-2567150000
@github-actions crossbow submit test-debian-experimental-cpp-gcc-15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org