[jira] [Commented] (LOG4NET-512) Thread safety issue in Hierarchy.cs

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LOG4NET-512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15256200#comment-15256200 ] 

ASF GitHub Bot commented on LOG4NET-512:
----------------------------------------

Github user JJoe2 commented on the pull request:

    https://github.com/apache/log4net/pull/25#issuecomment-214260923
  
    Added two commits including a fix for https://issues.apache.org/jira/browse/LOG4NET-512


> Thread safety issue in Hierarchy.cs
> -----------------------------------
>
>                 Key: LOG4NET-512
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-512
>             Project: Log4net
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.2.15
>            Reporter: Joe
>            Priority: Minor
>
> From inspecting the source code I believe there is a threading bug in the Hierarchy class.  Both of the methods Exists and GetCurrentLoggers access the internal hashtable m_ht without locking.
> Impact is minor as both these methods are probably rarely called by third party code, and since they do not modify state, the worst that can happen is an unexpected exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)