You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/10/06 14:20:54 UTC

[GitHub] [tvm-rfcs] Hzfengsy opened a new pull request #41: [RFC] Update script block syntax

Hzfengsy opened a new pull request #41:
URL: https://github.com/apache/tvm-rfcs/pull/41


   It's the rfc for a new block syntax in TVMScript.
   
   Co-authored-by: Junru Shao <ju...@gmail.com>
   Co-authored-by: Zihao Ye <zi...@gmail.com>
   Co-authored-by: Tianqi Chen <tq...@users.noreply.github.com>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm-rfcs] junrushao1994 commented on pull request #41: [RFC] Update script block syntax

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #41:
URL: https://github.com/apache/tvm-rfcs/pull/41#issuecomment-939069224


   I don't have other comments :-)  Going to merge this RFC in 24h if there is no objection


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm-rfcs] tqchen commented on pull request #41: [RFC] Update script block syntax

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #41:
URL: https://github.com/apache/tvm-rfcs/pull/41#issuecomment-938152672


   THanks @Hzfengsy , looks like a great update that makes the intend clear


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm-rfcs] junrushao1994 edited a comment on pull request #41: [RFC] Update script block syntax

Posted by GitBox <gi...@apache.org>.
junrushao1994 edited a comment on pull request #41:
URL: https://github.com/apache/tvm-rfcs/pull/41#issuecomment-936712366


   Rendered text: https://github.com/apache/tvm-rfcs/blob/3520bf8bdab86c60059edd937ad58331ecd7223f/rfcs/0041-script-block-syntax.md


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm-rfcs] junrushao1994 commented on pull request #41: [RFC] Update script block syntax

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #41:
URL: https://github.com/apache/tvm-rfcs/pull/41#issuecomment-936712366


   Rendered text: https://github.com/apache/tvm-rfcs/blob/67df92fea29d4e667adfe149d7b2b1420c344b47/rfcs/0041-script-block-syntax.md


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm-rfcs] Hzfengsy commented on pull request #41: [RFC] Update script block syntax

Posted by GitBox <gi...@apache.org>.
Hzfengsy commented on pull request #41:
URL: https://github.com/apache/tvm-rfcs/pull/41#issuecomment-937708016


   Thanks @junrushao1994. The reference has updated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm-rfcs] junrushao1994 commented on pull request #41: [RFC] Update script block syntax

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #41:
URL: https://github.com/apache/tvm-rfcs/pull/41#issuecomment-936887553


   The syntax of block bindings looks good to me! Specially it makes it really clear to the readers that there is a "block binding" to avoid future surprise.
   
   BTW, do we have a reference for the behavior of auto-completion on T.read/write?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm-rfcs] Hzfengsy commented on pull request #41: [RFC] Update script block syntax

Posted by GitBox <gi...@apache.org>.
Hzfengsy commented on pull request #41:
URL: https://github.com/apache/tvm-rfcs/pull/41#issuecomment-937708016


   Thanks @junrushao1994. The reference has updated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm-rfcs] tqchen merged pull request #41: [RFC] Update script block syntax

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #41:
URL: https://github.com/apache/tvm-rfcs/pull/41


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm-rfcs] tqchen commented on pull request #41: [RFC] Update script block syntax

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #41:
URL: https://github.com/apache/tvm-rfcs/pull/41#issuecomment-938152672


   THanks @Hzfengsy , looks like a great update that makes the intend clear


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org