You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/02/12 19:31:50 UTC
[GitHub] [airflow] potiuk opened a new pull request, #29495: Change permissions of config/password files created by airflow
potiuk opened a new pull request, #29495:
URL: https://github.com/apache/airflow/pull/29495
The permissions created by airflow when creating config and standalone files are now only limited to the owner.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #29495: Change permissions of config/password files created by airflow
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #29495:
URL: https://github.com/apache/airflow/pull/29495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #29495: Change permissions of config/password files created by airflow
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #29495:
URL: https://github.com/apache/airflow/pull/29495#discussion_r1112322251
##########
airflow/configuration.py:
##########
@@ -1545,6 +1548,12 @@ def initialize_config() -> AirflowConfigParser:
return local_conf
+def make_group_other_inaccessible(file_path: str):
+ with suppress(Exception):
+ permissions = os.stat(file_path)
+ os.chmod(file_path, permissions.st_mode & (stat.S_IRUSR | stat.S_IWUSR))
Review Comment:
Changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #29495: Change permissions of config/password files created by airflow
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #29495:
URL: https://github.com/apache/airflow/pull/29495#discussion_r1112320830
##########
airflow/configuration.py:
##########
@@ -1545,6 +1548,12 @@ def initialize_config() -> AirflowConfigParser:
return local_conf
+def make_group_other_inaccessible(file_path: str):
+ with suppress(Exception):
+ permissions = os.stat(file_path)
+ os.chmod(file_path, permissions.st_mode & (stat.S_IRUSR | stat.S_IWUSR))
Review Comment:
I'd say log an error, not to raise it. There might be various reasons why changing permissions is not possible - for example when the filesystem config file gets generated on happens to be NFS. Failing hard in this case is kinda strange at this point as the file has already been generated (so next time if we run airflow it will succeed because the whole branch is skiped in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Taragolis commented on a diff in pull request #29495: Change permissions of config/password files created by airflow
Posted by "Taragolis (via GitHub)" <gi...@apache.org>.
Taragolis commented on code in PR #29495:
URL: https://github.com/apache/airflow/pull/29495#discussion_r1111060706
##########
airflow/configuration.py:
##########
@@ -1545,6 +1548,12 @@ def initialize_config() -> AirflowConfigParser:
return local_conf
+def make_group_other_inaccessible(file_path: str):
+ with suppress(Exception):
+ permissions = os.stat(file_path)
+ os.chmod(file_path, permissions.st_mode & (stat.S_IRUSR | stat.S_IWUSR))
Review Comment:
Should we raise an error instead of suppress it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org