[GitHub] [flink-docker] zentol commented on pull request #116: [FLINK-27671][ci] Publish snapshot images to GHCR

[GitBox <gi...@apache.org>]

zentol commented on PR #116:
URL: https://github.com/apache/flink-docker/pull/116#issuecomment-1131474266

   > Would you be OK with adding add-custom.sh to master in that case?
   
   No; you can't add add-custom.sh to master because it's ultimately just a utility wrapper of the docker file generation scripts. we would have to move all of that to master, but that breaks the development model of flink-docker. It would also lock us out of creating snapshot images for other releases (e.g., 1.15).
   
   > I thought that we were going to put the snapshot.yaml to the dev-master branch. If I get you correctly, this won't work with the scheduled runs, because they can only be triggered from master. Is my understanding correct?
   
   Correct; the workflow file for the scheduled run must be defined in the master branch.
   
   However, you _can_ checkout other branches.
   
   I mentioned this before, but https://github.com/apache/flink/blob/master/.github/workflows/docs.yml is really good example on how to achieve this. You have the workflow defined on master, but it checks out the dev branches and uses the scripts from those branches to do stuff. You can think of the scripts on the dev branches to be a sort of interface that the scheduled run works against. This does imply that we _may_ duplicate some stuff from the workflow file (i.e., if we want to run ci), and we _may_ have issues when the scripts are being changed across versions. But that happens rarely enough that I'm not too worried about it.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org