You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by Stargazer4869 <gi...@git.apache.org> on 2018/01/22 03:23:05 UTC
[GitHub] tinkerpop pull request #788: TINKERPOP-1872 Apply edgeFunction in SparkMesse...
GitHub user Stargazer4869 opened a pull request:
https://github.com/apache/tinkerpop/pull/788
TINKERPOP-1872 Apply edgeFunction in SparkMessenger
Re-create the pull request to replace the one on master branch.
The edgeFunction defined in Local MessageScope will not be applied anywhere when you are using SparkGraphComputer. It will cause a difference in result with what you will have when you are using TinkerGraphComputer.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Stargazer4869/tinkerpop tp32
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/788.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #788
----
commit 744c4ecbc042acdc481045d6df5077d52d370ac9
Author: zhuchenchen <zh...@...>
Date: 2018-01-22T03:15:41Z
Apply edgeFunction in SparkMessenger
----
---
[GitHub] tinkerpop issue #788: TINKERPOP-1872 Apply edgeFunction in SparkMessenger
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/788
sorry, it too me a while to get to this. It looks like you have a good unit tests for `SparkMessenger` but is there an integration test that would also work so that it could be added to the general test suite. In this way we could see it executed against `TinkerMessenger` and potentially other places where an edgeFunction might be in use?
---
[GitHub] tinkerpop issue #788: TINKERPOP-1872 Apply edgeFunction in SparkMessenger
Posted by Stargazer4869 <gi...@git.apache.org>.
Github user Stargazer4869 commented on the issue:
https://github.com/apache/tinkerpop/pull/788
Hi, @spmallette
Is there an integration test case which involved TinkerMessenger or TinkerGraphComputer? I could write a similar one for SparkGraphComputer. It will make it easier for me to create an integration test case for SparkMessenger
---
[GitHub] tinkerpop issue #788: TINKERPOP-1872 Apply edgeFunction in SparkMessenger
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/788
Please see #793 which contains your changes here plus an integration test i was able to write to produce the problem. I wasn't sure how to advise you to do it, without doing it myself, so I hope you don't mind my finishing this one up for you. Please close this pull request when you get a moment...thanks.
---
[GitHub] tinkerpop pull request #788: TINKERPOP-1872 Apply edgeFunction in SparkMesse...
Posted by Stargazer4869 <gi...@git.apache.org>.
Github user Stargazer4869 closed the pull request at:
https://github.com/apache/tinkerpop/pull/788
---