You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "kparzysz-quic (via GitHub)" <gi...@apache.org> on 2023/06/20 22:53:52 UTC
[GitHub] [tvm] kparzysz-quic opened a new pull request, #15130: [Unity][Relax] Check for call_tir early in DataflowReshapeRewriter
kparzysz-quic opened a new pull request, #15130:
URL: https://github.com/apache/tvm/pull/15130
In an earlier commit, the check for `call_tir` was moved until later, which exposed some of the code to any calls, not just `call_tir`. The code was making assumptions about some of the arguments, which now are not necessarily met. Specifically, that there are at least two arguments, and that the first argument was a `GlobalVar`.
Move the check for `call_tir` back to the beginning of the function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #15130: [Unity][Relax] Check for call_tir early in DataflowReshapeRewriter
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #15130:
URL: https://github.com/apache/tvm/pull/15130#issuecomment-1599682133
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @junrushao, @quic-sanirudh <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] kparzysz-quic commented on pull request #15130: [Unity][Relax] Check for call_tir early in DataflowReshapeRewriter
Posted by "kparzysz-quic (via GitHub)" <gi...@apache.org>.
kparzysz-quic commented on PR #15130:
URL: https://github.com/apache/tvm/pull/15130#issuecomment-1599718488
You have a testcase, so let's go with yours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] kparzysz-quic commented on pull request #15130: [Unity][Relax] Check for call_tir early in DataflowReshapeRewriter
Posted by "kparzysz-quic (via GitHub)" <gi...@apache.org>.
kparzysz-quic commented on PR #15130:
URL: https://github.com/apache/tvm/pull/15130#issuecomment-1599683613
Sorry, I missed that thing in the last commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #15130: [Unity][Relax] Check for call_tir early in DataflowReshapeRewriter
Posted by "masahi (via GitHub)" <gi...@apache.org>.
masahi commented on PR #15130:
URL: https://github.com/apache/tvm/pull/15130#issuecomment-1599695509
yeah I have https://github.com/apache/tvm/pull/15125 as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #15130: [Unity][Relax] Check for call_tir early in DataflowReshapeRewriter
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #15130:
URL: https://github.com/apache/tvm/pull/15130#issuecomment-1599682164
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @junrushao, @quic-sanirudh <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] kparzysz-quic closed pull request #15130: [Unity][Relax] Check for call_tir early in DataflowReshapeRewriter
Posted by "kparzysz-quic (via GitHub)" <gi...@apache.org>.
kparzysz-quic closed pull request #15130: [Unity][Relax] Check for call_tir early in DataflowReshapeRewriter
URL: https://github.com/apache/tvm/pull/15130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org