You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Emmanuel Bourg <sm...@lfjr.net> on 2004/09/20 12:27:48 UTC

[configuration] Set is package private?!?

henning@apache.org wrote:

> henning     2004/09/20 02:48:40
> 
>   Modified:    configuration/src/java/org/apache/commons/configuration
>                         ConfigurationMap.java ConfigurationSet.java
>   Log:
>   Map is public, Set is package private?!?

Yes it's package private because it's just used to implement the 
keySet() method of ConfigurationMap, there is no reason to make it 
public since it's useless for end users.

Emmanuel Bourg


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


RE: [configuration] Set is package private?!?

Posted by Eric Pugh <ep...@upstate.com>.
b/c inner classes are icky and make my head hurt :-)   No, I don't have a
specific urge to keep it seperate...

eric

> -----Original Message-----
> From: Henning P. Schmiedehausen [mailto:hps@intermeta.de]
> Sent: Monday, September 20, 2004 6:54 PM
> To: commons-dev@jakarta.apache.org
> Subject: Re: [configuration] Set is package private?!?
>
>
> Emmanuel Bourg <sm...@lfjr.net> writes:
>
> >Henning P. Schmiedehausen wrote:
>
> >> Is it? I agree that I see no obvious usage for it, but our users have
> >> been proven to be imaginative. Else it should (IMHO) either be an
> >> inner class to ConfigurationMap or at least moved to a sub-package.
> >>
> >> 	Regards
> >> 		Henning
>
> >This class is really an implementation detail, as a package private
> >class or private (anonymous?) inner class I have no preference, but not
> >public.
>
> Ok. Any objections for moving it as an inner class into ConfigurationMap ?
>
> 	Regards
> 		Henning
>
> --
> Dipl.-Inf. (Univ.) Henning P. Schmiedehausen          INTERMETA GmbH
> hps@intermeta.de        +49 9131 50 654 0   http://www.intermeta.de/
>
> RedHat Certified Engineer -- Jakarta Turbine Development  -- hero for hire
>    Linux, Java, perl, Solaris -- Consulting, Training, Development
>
> "Fighting for one's political stand is an honorable action, but re-
>  fusing to acknowledge that there might be weaknesses in one's
>  position - in order to identify them so that they can be remedied -
>  is a large enough problem with the Open Source movement that it
>  deserves to be on this list of the top five problems."
>                        -- Michelle Levesque, "Fundamental Issues with
>                                     Open Source Software Development"
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [configuration] Set is package private?!?

Posted by "Henning P. Schmiedehausen" <hp...@intermeta.de>.
Emmanuel Bourg <sm...@lfjr.net> writes:

>Henning P. Schmiedehausen wrote:

>> Is it? I agree that I see no obvious usage for it, but our users have
>> been proven to be imaginative. Else it should (IMHO) either be an
>> inner class to ConfigurationMap or at least moved to a sub-package.
>> 
>> 	Regards
>> 		Henning

>This class is really an implementation detail, as a package private 
>class or private (anonymous?) inner class I have no preference, but not 
>public.

Ok. Any objections for moving it as an inner class into ConfigurationMap ?

	Regards
		Henning

-- 
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen          INTERMETA GmbH
hps@intermeta.de        +49 9131 50 654 0   http://www.intermeta.de/

RedHat Certified Engineer -- Jakarta Turbine Development  -- hero for hire
   Linux, Java, perl, Solaris -- Consulting, Training, Development

"Fighting for one's political stand is an honorable action, but re-
 fusing to acknowledge that there might be weaknesses in one's
 position - in order to identify them so that they can be remedied -
 is a large enough problem with the Open Source movement that it
 deserves to be on this list of the top five problems."
                       -- Michelle Levesque, "Fundamental Issues with
                                    Open Source Software Development"

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [configuration] Set is package private?!?

Posted by Emmanuel Bourg <sm...@lfjr.net>.
Henning P. Schmiedehausen wrote:

> Is it? I agree that I see no obvious usage for it, but our users have
> been proven to be imaginative. Else it should (IMHO) either be an
> inner class to ConfigurationMap or at least moved to a sub-package.
> 
> 	Regards
> 		Henning

This class is really an implementation detail, as a package private 
class or private (anonymous?) inner class I have no preference, but not 
public.


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [configuration] Set is package private?!?

Posted by "Henning P. Schmiedehausen" <hp...@intermeta.de>.
Emmanuel Bourg <sm...@lfjr.net> writes:

>henning@apache.org wrote:

>> henning     2004/09/20 02:48:40
>> 
>>   Modified:    configuration/src/java/org/apache/commons/configuration
>>                         ConfigurationMap.java ConfigurationSet.java
>>   Log:
>>   Map is public, Set is package private?!?

>Yes it's package private because it's just used to implement the 
>keySet() method of ConfigurationMap, there is no reason to make it 
>public since it's useless for end users.

Is it? I agree that I see no obvious usage for it, but our users have
been proven to be imaginative. Else it should (IMHO) either be an
inner class to ConfigurationMap or at least moved to a sub-package.

	Regards
		Henning

-- 
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen          INTERMETA GmbH
hps@intermeta.de        +49 9131 50 654 0   http://www.intermeta.de/

RedHat Certified Engineer -- Jakarta Turbine Development  -- hero for hire
   Linux, Java, perl, Solaris -- Consulting, Training, Development

"Fighting for one's political stand is an honorable action, but re-
 fusing to acknowledge that there might be weaknesses in one's
 position - in order to identify them so that they can be remedied -
 is a large enough problem with the Open Source movement that it
 deserves to be on this list of the top five problems."
                       -- Michelle Levesque, "Fundamental Issues with
                                    Open Source Software Development"

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org