[Impala-ASF-CR] IMPALA-8198: DATE: Read from avro.

["Tim Armstrong (Code Review)" <ge...@cloudera.org>]

Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13944 )

Change subject: IMPALA-8198: DATE: Read from avro.
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13944/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/13944/1//COMMIT_MSG@27
PS1, Line 27: Note that Hive 3.1 switched to proleptic Gregorian calendar too, so
I didn't see anything in the tests that expects different results for Hive 2 and 3. We support running tests with both Hive 2 and 3, so I would have expected to see something like that.


http://gerrit.cloudera.org:8080/#/c/13944/1/be/src/exec/hdfs-avro-scanner.cc
File be/src/exec/hdfs-avro-scanner.cc:

http://gerrit.cloudera.org:8080/#/c/13944/1/be/src/exec/hdfs-avro-scanner.cc@1025
PS1, Line 1025:       read_field_fn = codegen->GetFunction(IRFunction::READ_AVRO_DATE, false);
Why is the branch condition here different from the interpreted MaterializeTuple() function? In that function we were branching on both the schema type and the slot type.



-- 
To view, visit http://gerrit.cloudera.org:8080/13944
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a9d5b93a22cf3a00244037e187f8c145cacc959
Gerrit-Change-Number: 13944
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Jeges <at...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Aug 2019 22:06:53 +0000
Gerrit-HasComments: Yes