You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Daryn Sharp (JIRA)" <ji...@apache.org> on 2011/04/29 16:51:03 UTC
[jira] [Created] (HADOOP-7251) Refactor FsShell's getmerge
Refactor FsShell's getmerge
---------------------------
Key: HADOOP-7251
URL: https://issues.apache.org/jira/browse/HADOOP-7251
Project: Hadoop Common
Issue Type: Improvement
Components: fs
Affects Versions: 0.23.0
Reporter: Daryn Sharp
Assignee: Daryn Sharp
Need to refactor getmerge to conform to new FsCommand class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7251) Refactor FsShell's getmerge
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028844#comment-13028844 ]
Hadoop QA commented on HADOOP-7251:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12478182/HADOOP-7251-2.patch
against trunk revision 1099284.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/397//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/397//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/397//console
This message is automatically generated.
> Refactor FsShell's getmerge
> ---------------------------
>
> Key: HADOOP-7251
> URL: https://issues.apache.org/jira/browse/HADOOP-7251
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7251-2.patch, HADOOP-7251.patch
>
>
> Need to refactor getmerge to conform to new FsCommand class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7251) Refactor FsShell's getmerge
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030144#comment-13030144 ]
Hudson commented on HADOOP-7251:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #579 (See [https://builds.apache.org/hudson/job/Hadoop-Common-trunk-Commit/579/])
HADOOP-7251. Refactor the getmerge command to conform to new FsCommand class. Contributed by Daryn Sharp
> Refactor FsShell's getmerge
> ---------------------------
>
> Key: HADOOP-7251
> URL: https://issues.apache.org/jira/browse/HADOOP-7251
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.0
>
> Attachments: HADOOP-7251-2.patch, HADOOP-7251.patch
>
>
> Need to refactor getmerge to conform to new FsCommand class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7251) Refactor FsShell's getmerge
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028816#comment-13028816 ]
Matt Foley commented on HADOOP-7251:
------------------------------------
I understand that the lifetime of the Merge object is only a single invocation, but I would prefer to have Merge.delimiter conditionally set to either null or "\n" at the decision point in processOptions(), in addition to being initialized to null by ctor. It's just to remove concern about re-use, or in case the object ever changes to be re-used.
> Refactor FsShell's getmerge
> ---------------------------
>
> Key: HADOOP-7251
> URL: https://issues.apache.org/jira/browse/HADOOP-7251
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7251.patch
>
>
> Need to refactor getmerge to conform to new FsCommand class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7251) Refactor FsShell's getmerge
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-7251:
-------------------------------------------
Resolution: Fixed
Fix Version/s: 0.23.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I have committed this. Thanks, Daryn!
Thanks also Matt for reviewing it.
> Refactor FsShell's getmerge
> ---------------------------
>
> Key: HADOOP-7251
> URL: https://issues.apache.org/jira/browse/HADOOP-7251
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.0
>
> Attachments: HADOOP-7251-2.patch, HADOOP-7251.patch
>
>
> Need to refactor getmerge to conform to new FsCommand class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7251) Refactor FsShell's getmerge
Posted by "Matt Foley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13028978#comment-13028978 ]
Matt Foley commented on HADOOP-7251:
------------------------------------
Never mind about the ctor, I wasn't expressing myself clearly.
This new patch changed exactly what I asked for.
+1.
> Refactor FsShell's getmerge
> ---------------------------
>
> Key: HADOOP-7251
> URL: https://issues.apache.org/jira/browse/HADOOP-7251
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7251-2.patch, HADOOP-7251.patch
>
>
> Need to refactor getmerge to conform to new FsCommand class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7251) Refactor FsShell's getmerge
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-7251:
--------------------------------
Status: Patch Available (was: Open)
> Refactor FsShell's getmerge
> ---------------------------
>
> Key: HADOOP-7251
> URL: https://issues.apache.org/jira/browse/HADOOP-7251
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7251.patch
>
>
> Need to refactor getmerge to conform to new FsCommand class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7251) Refactor FsShell's getmerge
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-7251:
--------------------------------
Attachment: HADOOP-7251-2.patch
Thanks for the comments!
The method parseOptions is now explicitly defining the delimiter to be null or newline in event of re-use -- which isn't currently possible, but is a good idea.
I'm not sure I understand the value of adding a ctor to explicitly set an instance var to null, when the instance var is already initialized to null? Did I misunderstand?
> Refactor FsShell's getmerge
> ---------------------------
>
> Key: HADOOP-7251
> URL: https://issues.apache.org/jira/browse/HADOOP-7251
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7251-2.patch, HADOOP-7251.patch
>
>
> Need to refactor getmerge to conform to new FsCommand class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HADOOP-7251) Refactor FsShell's getmerge
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daryn Sharp updated HADOOP-7251:
--------------------------------
Attachment: HADOOP-7251.patch
> Refactor FsShell's getmerge
> ---------------------------
>
> Key: HADOOP-7251
> URL: https://issues.apache.org/jira/browse/HADOOP-7251
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7251.patch
>
>
> Need to refactor getmerge to conform to new FsCommand class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7251) Refactor FsShell's getmerge
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13027136#comment-13027136 ]
Hadoop QA commented on HADOOP-7251:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12477765/HADOOP-7251.patch
against trunk revision 1097322.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/388//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/388//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-HADOOP-Build/388//console
This message is automatically generated.
> Refactor FsShell's getmerge
> ---------------------------
>
> Key: HADOOP-7251
> URL: https://issues.apache.org/jira/browse/HADOOP-7251
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Attachments: HADOOP-7251.patch
>
>
> Need to refactor getmerge to conform to new FsCommand class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HADOOP-7251) Refactor FsShell's getmerge
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030317#comment-13030317 ]
Hudson commented on HADOOP-7251:
--------------------------------
Integrated in Hadoop-Common-trunk #681 (See [https://builds.apache.org/hudson/job/Hadoop-Common-trunk/681/])
HADOOP-7251. Refactor the getmerge command to conform to new FsCommand class. Contributed by Daryn Sharp
> Refactor FsShell's getmerge
> ---------------------------
>
> Key: HADOOP-7251
> URL: https://issues.apache.org/jira/browse/HADOOP-7251
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Daryn Sharp
> Assignee: Daryn Sharp
> Fix For: 0.23.0
>
> Attachments: HADOOP-7251-2.patch, HADOOP-7251.patch
>
>
> Need to refactor getmerge to conform to new FsCommand class.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira