You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "yuzelin (via GitHub)" <gi...@apache.org> on 2025/08/21 05:52:32 UTC

[PR] [core] FileEntry supports file creation time [paimon]

yuzelin opened a new pull request, #6109:
URL: https://github.com/apache/paimon/pull/6109

   <!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
   
   ### Purpose
   
   <!-- Linking this pull request to the issue -->
   Linked issue: close #xxx
   
   <!-- What is the purpose of the change -->
   
   ### Tests
   
   <!-- List UT and IT cases to verify this change -->
   
   ### API and Format
   
   <!-- Does this change affect API or storage format -->
   
   ### Documentation
   
   <!-- Does this change introduce a new feature -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [core] FileEntry supports file creation time [paimon]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6109:
URL: https://github.com/apache/paimon/pull/6109#issuecomment-4410757363

   This pull request has had no activity for 90 days. If you'd like to keep it open, please push a new commit or leave a comment. Thanks for the contribution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [core] FileEntry supports file creation time [paimon]

Posted by "yuzelin (via GitHub)" <gi...@apache.org>.
yuzelin closed pull request #6109: [core] FileEntry supports file creation time
URL: https://github.com/apache/paimon/pull/6109


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [core] FileEntry supports file creation time [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #6109:
URL: https://github.com/apache/paimon/pull/6109#discussion_r2297556097


##########
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreScan.java:
##########
@@ -106,11 +106,15 @@ default Long totalRecordCount(Snapshot snapshot) {
                 : snapshot.totalRecordCount();
     }
 
+    default List<SimpleFileEntry> readSimpleEntries() {
+        return readSimpleEntries(false);
+    }
+
     /**
      * Read {@link SimpleFileEntry}s, SimpleFileEntry only retains some critical information, so it
      * cannot perform filtering based on statistical information.
      */
-    List<SimpleFileEntry> readSimpleEntries();
+    List<SimpleFileEntry> readSimpleEntries(boolean containsTime);

Review Comment:
   Can you introduce another method `readSimpleEntries(boolean containsTime)`? Keep old `readSimpleEntries()`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [core] FileEntry supports file creation time [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #6109:
URL: https://github.com/apache/paimon/pull/6109#discussion_r2297554133


##########
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommit.java:
##########
@@ -36,6 +36,8 @@ public interface FileStoreCommit extends AutoCloseable {
 
     FileStoreCommit withPartitionExpire(PartitionExpire partitionExpire);
 
+    FileStoreCommit baseEntryContainsTime(boolean ignoreEmptyCommit);

Review Comment:
   ignoreEmptyCommit?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [core] FileEntry supports file creation time [paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #6109:
URL: https://github.com/apache/paimon/pull/6109#issuecomment-3209120653

   Can you add a new FileEntry implementation class instead of modifying FileEntry?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org