You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "Croway (via GitHub)" <gi...@apache.org> on 2023/03/09 10:17:16 UTC
[GitHub] [camel] Croway opened a new pull request, #9493: CAMEL-18508: Polish user config
Croway opened a new pull request, #9493:
URL: https://github.com/apache/camel/pull/9493
# Description
<!--
- Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
-->
# Target
- [ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [ ] I formatted the code using `mvn -Pformat,fastinstall install && mvn -Psourcecheck`
<!--
You can run the aforementioned command in your module so that the build auto-formats your code and the source check verifies that is complies with our coding style. This will also be verified as part of the checks and your PR may be rejected if the checkstyle does not pass.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9493: CAMEL-18508: Polish user config
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9493:
URL: https://github.com/apache/camel/pull/9493#issuecomment-1461813694
:no_entry_sign: There are (likely) no components to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] Croway merged pull request #9493: CAMEL-18508: Polish user config
Posted by "Croway (via GitHub)" <gi...@apache.org>.
Croway merged PR #9493:
URL: https://github.com/apache/camel/pull/9493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a diff in pull request #9493: CAMEL-18508: Polish user config
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #9493:
URL: https://github.com/apache/camel/pull/9493#discussion_r1130774827
##########
docs/user-manual/modules/ROOT/pages/camel-jbang.adoc:
##########
@@ -1809,32 +1809,32 @@ NOTE: These are options from the export command, so you can see mor details and
== Configuration
-Camel JBang can be used to store and use user configuration so that cli options won't have to be specified each time, for example, in order to run a different camel version, instead of executing
+Camel JBang `config` command is used to store and use the user configuration. This eliminates the need to specify CLI options each time. For example, to run a different camel version, instead of executing
Review Comment:
camel -> Camel
##########
docs/user-manual/modules/ROOT/pages/camel-jbang.adoc:
##########
@@ -1809,32 +1809,32 @@ NOTE: These are options from the export command, so you can see mor details and
== Configuration
-Camel JBang can be used to store and use user configuration so that cli options won't have to be specified each time, for example, in order to run a different camel version, instead of executing
+Camel JBang `config` command is used to store and use the user configuration. This eliminates the need to specify CLI options each time. For example, to run a different camel version, instead of executing
[source,bash]
----
camel run * --camel-version=3.18.4
----
-the option camel-version can be added to the user configuration like
+the camel-version can be added to the user configuration such as:
[source,bash]
----
camel config set camel-version=3.18.4
----
-and then, the run command will pick the user configuration
+Now, the run command picks the user configuration:
[source,bash]
----
camel run *
----
-The user configuration file will be stored in ~/.camel-jbang-user.properties
+The user configuration file is stored in ~/.camel-jbang-user.properties
Review Comment:
it may be nice to put single quote around the file name so it stand out a bit better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9493: CAMEL-18508: Polish user config
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9493:
URL: https://github.com/apache/camel/pull/9493#issuecomment-1461852562
:no_entry_sign: There are (likely) no components to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org