You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/16 13:37:29 UTC

[GitHub] [incubator-superset] codecov-commenter commented on pull request #10870: ESLint: Re-enable rule no-access-state-in-setstate

codecov-commenter commented on pull request #10870:
URL: https://github.com/apache/incubator-superset/pull/10870#issuecomment-693410552


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=h1) Report
   > Merging [#10870](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d93b2b99b28c66f0815637b9f8a5fecae3a4e33c?el=desc) will **increase** coverage by `2.78%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10870/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10870      +/-   ##
   ==========================================
   + Coverage   59.21%   61.99%   +2.78%     
   ==========================================
     Files         776      382     -394     
     Lines       37040    24595   -12445     
     Branches     3309        0    -3309     
   ==========================================
   - Hits        21932    15247    -6685     
   + Misses      14922     9348    -5574     
   + Partials      186        0     -186     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #python | `61.99% <ø> (+0.69%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/models/dashboard.py](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `87.94% <0.00%> (-0.38%)` | :arrow_down: |
   | [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
   | [superset/utils/cache\_manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGVfbWFuYWdlci5weQ==) | `100.00% <0.00%> (ø)` | |
   | [.../explore/components/controls/DatasourceControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRhc291cmNlQ29udHJvbC5qc3g=) | | |
   | [...end/src/dashboard/util/getKeyForFilterScopeTree.js](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEtleUZvckZpbHRlclNjb3BlVHJlZS5qcw==) | | |
   | [...t-frontend/src/dashboard/reducers/dashboardInfo.js](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy9kYXNoYm9hcmRJbmZvLmpz) | | |
   | [...set-frontend/src/dashboard/util/resizableConfig.ts](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL3Jlc2l6YWJsZUNvbmZpZy50cw==) | | |
   | [...t-frontend/src/components/Select/OnPasteSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L09uUGFzdGVTZWxlY3QuanN4) | | |
   | [...perset-frontend/src/explore/components/Control.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLmpzeA==) | | |
   | [...nd/src/dashboard/util/getFilterScopeParentNodes.js](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlUGFyZW50Tm9kZXMuanM=) | | |
   | ... and [373 more](https://codecov.io/gh/apache/incubator-superset/pull/10870/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=footer). Last update [d93b2b9...9e6a742](https://codecov.io/gh/apache/incubator-superset/pull/10870?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org